-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate Array class #343
Merged
DanPuzzuoli
merged 6 commits into
qiskit-community:main
from
DanPuzzuoli:deprecate-Array
Mar 15, 2024
+67
−8
Merged
Changes from 4 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
1471f3b
adding deprecation warning for Array class, and upgrade note
DanPuzzuoli 28bce48
fixing jax optimization tutorial
DanPuzzuoli 6cd401d
suppressing warnigns in Array docs, adding deprecation warnings at th…
DanPuzzuoli 18874c5
fixing warnings filter for docs
DanPuzzuoli b4166af
Merge branch 'main' into deprecate-Array
DanPuzzuoli c81ca79
adding link in deprecation text
DanPuzzuoli File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 changes: 9 additions & 0 deletions
9
releasenotes/notes/dispatch-array-deprecation-fb945946caba447a.yaml
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,9 @@ | ||
--- | ||
upgrade: | ||
- | | ||
The ``array`` and ``dispatch`` submodules of Qiskit Dynamics have been deprecated as of version | ||
0.5.0. The use of the ``Array`` class is no longer required to work with different array | ||
libraries in Qiskit Dynamics, and is broken in some cases. Refer to the user guide entry on | ||
using different array libraries with Qiskit Dynamics. Users can now work directly with the | ||
supported array type of their choice, without the need to wrap them to enable dispatching. The | ||
``array`` and ``dispatch`` submodules will be removed in version 0.6.0. |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it possible add any link to this userguide?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes thanks, good idea. I've just added the link to this text.
Also this comment made me realize I accidentally put this warning in the
arraylias
submodule docs, as opposed to thedispatch
submodule docs :D. I've also corrected this.