Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate Array class #343

Merged
merged 6 commits into from
Mar 15, 2024
Merged

Conversation

DanPuzzuoli
Copy link
Collaborator

Summary

Deprecating Array class, and adding release upgrade note.

Details and comments

@DanPuzzuoli DanPuzzuoli requested a review from to24toro March 12, 2024 17:34

The ``array`` and ``dispatch`` submodules of Qiskit Dynamics have been deprecated as of version
0.5.0. The use of the ``Array`` class is no longer required to work with different array
libraries in Qiskit Dynamics, and is broken in some cases. Refer to the user guide entry on
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible add any link to this userguide?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes thanks, good idea. I've just added the link to this text.

Also this comment made me realize I accidentally put this warning in the arraylias submodule docs, as opposed to the dispatch submodule docs :D. I've also corrected this.

@DanPuzzuoli DanPuzzuoli requested a review from to24toro March 15, 2024 14:53
Copy link
Contributor

@to24toro to24toro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. LGTM!

@DanPuzzuoli DanPuzzuoli merged commit fdf27ba into qiskit-community:main Mar 15, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants