Rename subsystem_dims of Dict to subsystem_dims_dict #250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to24toro
force-pushed
the
feature/rename_subsystem_dims
branch
from
1f48068 to
1471732
Compare
DanPuzzuoli
approved these changes
Jul 31, 2023
DanPuzzuoli
pushed a commit
to DanPuzzuoli/qiskit-dynamics
that referenced
this pull request
Aug 2, 2023
DanPuzzuoli
added a commit
that referenced
this pull request
Aug 8, 2023
* adding sympy as an explicit requirement (#233) * Add warning for JAX versions on import of Dynamics (#232) * Add probability normalization to DynamicsBackend sampling routine (#239) * Add warning if digital carrier exceeds Nyquist frequency in pulse -> signal conversion (#242) * Fix bug with carrier_freq being a JAX tracer if envelope is constant in Signal (#247) * Remove subsystem_labels option from DynamicsBackend (#248) * Rename subsystem_dims Dict to subsystem_dims_dict (#250) * Fix ClassicalRegister counting in DynamicsBackend (#252) * temporary fix for docs (#253) * Drop support for backendV2 in from_backend (#249) * incrementing version number * cleaning up reno files --------- Co-authored-by: Kento Ueda <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
related to #248 .
After merging #248 , need to review.
Details and comments
Refactored the name of
subsystem_dimsof Dict tosubsystem_dims_dict.It is subtle changes and doesn't produce API breaking. But I can close if you want to leave the name.