Drop support for backendV2 in from_backend and _to_schedule_list #249
Conversation
| @@ -958,7 +958,7 @@ def _get_acquire_instruction_timings( | |||
|
|
|||
|
|
|||
| def _to_schedule_list( | |||
| run_input: List[Union[QuantumCircuit, Schedule, ScheduleBlock]], backend: BackendV2 | |||
| run_input: List[Union[QuantumCircuit, Schedule, ScheduleBlock]], backend: BackendV1 | |||
There was a problem hiding this comment.
This is actually called only on DynamicsBackend, which is BackendV2. I'm assuming it works on DynamicsBackend otherwise DynamicsBackend would never work. Is this issue in Terra in the main branch or on a current release?
There was a problem hiding this comment.
Oh, sorry I misunderstood it. We cannot change this type hint.
Anyway, DynamicsBackend would never work if it has the same architecture as backendV2. I haven't solved this issue in the current release 0.25 because I found other bugs in the current code in terra. However, I am not sure if DynamicsBackend would not work in fact because for example, DynamicsBackend enable to measure all qubits independently which is different from the real ibm backend.
p.s.
Scheduling with backendV2 needs meas_map and DynamicsBackend has to have meas_map. (#248 (comment))
There was a problem hiding this comment.
I fixed at bf2cdc5 once.
|
The only other thing I'm wondering with this PR is, now that we are removing |
…end' into feature/change_type_hint_of_backend
Co-authored-by: Daniel Puzzuoli <[email protected]>
* adding sympy as an explicit requirement (#233) * Add warning for JAX versions on import of Dynamics (#232) * Add probability normalization to DynamicsBackend sampling routine (#239) * Add warning if digital carrier exceeds Nyquist frequency in pulse -> signal conversion (#242) * Fix bug with carrier_freq being a JAX tracer if envelope is constant in Signal (#247) * Remove subsystem_labels option from DynamicsBackend (#248) * Rename subsystem_dims Dict to subsystem_dims_dict (#250) * Fix ClassicalRegister counting in DynamicsBackend (#252) * temporary fix for docs (#253) * Drop support for backendV2 in from_backend (#249) * incrementing version number * cleaning up reno files --------- Co-authored-by: Kento Ueda <[email protected]>
Summary
closes #236.
Details and comments
The type hint of an argument
backendinfrom_backendsupports both backendV1 and backendV2. However, we found it confuses people because almost all backendV2 cannot be used for dynamics backend in reality.In addition, I changed the type hint of an argument
backendfromBackendV2toBackendV1in_to_schedule_list. In_to_schedule_list,build_scheduleis used. Scheduling with backendV2 fails because of some bugs in terra. I am assigned to work on it but cannot solve it yet.In the future, supporting
BackendV2again in these functions is essential for users.