Update minor comments in pulse sim tutorial to remove confusion #228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanPuzzuoli
added a commit
to DanPuzzuoli/qiskit-dynamics
that referenced
this pull request
Jun 8, 2023
DanPuzzuoli
added a commit
that referenced
this pull request
Jun 9, 2023
* Temporary upper bound on JAX version <=0.4.6 and update to DynamicsBackend tutorial (#210) * Add links of API reference to tutorials and userguides (#212) * Fix multiset ordering bug in perturbation module (#211) Co-authored-by: Ian Hincks <[email protected]> * Bump Sphinx Theme to 1.11 (#215) * Bump Sphinx Theme to 1.11 * Also activate jquery * Bug fix: Measurement properties automatic padding for DynamicsBackend initialization (#209) Co-authored-by: Daniel Puzzuoli <[email protected]> * bounding ipython version for compatibility with python 3.8 (#216) * Update deploy_documentation.sh to deploy in ecosystem (#219) * Bound Diffrax version (#226) * Bounding diffrax and equinox versions. The latest versions require the latest version of JAX, but due to an unresolved bug in JAX, Dynamics is only compatible with jax<=0.4.6. This commit also adds a release note stating exactly what versions of these packages will work with the latest version of dynamics. * Upgrade to qiskit_sphinx_theme 1.12 (#224) * Update links to repo and documentation (#227) * updating minor comments in pulse sim tutorial to remove confusion (#228) * adding max step size argument to dynamics_backend tutorial, with explanation (#229) * fixing typo --------- Co-authored-by: Kento Ueda <[email protected]> Co-authored-by: Ian Hincks <[email protected]> Co-authored-by: Eric Arellano <[email protected]> Co-authored-by: Arthur Strauss <[email protected]> Co-authored-by: Luciano Bello <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The pulse simulation tutorial has a couple contradictory comments about whether some pulse parameters are meant to implement an X or SX gate. This PR makes it clear that the parameters are for an SX gate.