-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Python 3.12 and drop 3.8 #40
Changes from 9 commits
19db858
947092a
ddf4fe9
497cedf
f86423b
81f2b4d
fccb5ff
76eb0ea
f25f2f6
83b6d26
50f5a42
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
--- | ||
upgrade: | ||
- | | ||
Support for Python 3.12 has been added, and 3.8 has been dropped. |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -163,8 +163,8 @@ def test_eigh(self): | |
""" | ||
w_usp, v_usp = usp.linalg.eigh(self.arr_2d) | ||
w, v = scipy.linalg.eigh(self.arr_2d) | ||
self.assertTrue(usp.allclose(w, w_usp)) | ||
self.assertTrue(usp.allclose(v, v_usp)) | ||
self.assertTrue(unp.allclose(w, w_usp)) | ||
self.assertTrue(unp.allclose(v, v_usp)) | ||
Comment on lines
+166
to
+167
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Why this change? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This code previously used This is also what caused your docs PR to fail. |
||
|
||
|
||
class TestJaxScipyAlias(JaxBase, TestScipyAlias): | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this is true anymore. https://pypi.org/project/tensorflow/#files has 3.9-3.11
But fine to deal with in a dedicated PR to avoid a can of worms.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Trying to update this here - since this PR is about updating python versions I think it's fine to handle it here.