-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Python 3.12 and drop 3.8 #40
Add Python 3.12 and drop 3.8 #40
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
self.assertTrue(unp.allclose(w, w_usp)) | ||
self.assertTrue(unp.allclose(v, v_usp)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why this change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This code previously used usp
instead of unp
, but scipy.allclose
does not exist (which would be necessary for usp
to work). It's possible this was removed in a newer version of scipy since the last time the tests were run; otherwise I'm confused that the code here used to work.
This is also what caused your docs PR to fail.
requirements-dev.txt
Outdated
@@ -20,5 +20,5 @@ jax; sys_platform == 'darwin' or sys_platform == 'linux' | |||
jaxlib; sys_platform == 'darwin' or sys_platform == 'linux' | |||
|
|||
# Tensorflow does not yet have a 3.11 version |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this is true anymore. https://pypi.org/project/tensorflow/#files has 3.9-3.11
But fine to deal with in a dedicated PR to avoid a can of worms.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Trying to update this here - since this PR is about updating python versions I think it's fine to handle it here.
Co-authored-by: to24toro <[email protected]>
Co-authored-by: to24toro <[email protected]>
Summary
Closes #39
Details and comments