Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Python 3.12 and drop 3.8 #40

Merged
merged 11 commits into from
Feb 20, 2024

Conversation

DanPuzzuoli
Copy link
Collaborator

Summary

Closes #39

Details and comments

@DanPuzzuoli DanPuzzuoli requested a review from to24toro February 15, 2024 00:22
Copy link
Contributor

@Eric-Arellano Eric-Arellano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Comment on lines +166 to +167
self.assertTrue(unp.allclose(w, w_usp))
self.assertTrue(unp.allclose(v, v_usp))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this change?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This code previously used usp instead of unp, but scipy.allclose does not exist (which would be necessary for usp to work). It's possible this was removed in a newer version of scipy since the last time the tests were run; otherwise I'm confused that the code here used to work.

This is also what caused your docs PR to fail.

@@ -20,5 +20,5 @@ jax; sys_platform == 'darwin' or sys_platform == 'linux'
jaxlib; sys_platform == 'darwin' or sys_platform == 'linux'

# Tensorflow does not yet have a 3.11 version
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is true anymore. https://pypi.org/project/tensorflow/#files has 3.9-3.11

But fine to deal with in a dedicated PR to avoid a can of worms.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trying to update this here - since this PR is about updating python versions I think it's fine to handle it here.

@DanPuzzuoli DanPuzzuoli merged commit 16446bc into qiskit-community:main Feb 20, 2024
16 checks passed
DanPuzzuoli added a commit to DanPuzzuoli/arraylias that referenced this pull request Feb 20, 2024
DanPuzzuoli added a commit that referenced this pull request Feb 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Drop 3.8 and add 3.12
3 participants