Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for GPU tests and GPU workflow #200

Merged
merged 9 commits into from
Jan 31, 2025

Conversation

BrunoLiegiBastonLiegi
Copy link
Contributor

@BrunoLiegiBastonLiegi BrunoLiegiBastonLiegi commented Jan 24, 2025

Playing around with numba threading in combination with qiboteam/qibo#1561

@andrea-pasquale this PR houses eventual fixes needed by qiboteam/qibo#1561.

Copy link

codecov bot commented Jan 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.91%. Comparing base (b782805) to head (dd5bfc0).
Report is 20 commits behind head on cupy_matrices.

Additional details and impacted files
@@              Coverage Diff               @@
##           cupy_matrices     #200   +/-   ##
==============================================
  Coverage          99.91%   99.91%           
==============================================
  Files                 12       12           
  Lines               1115     1116    +1     
==============================================
+ Hits                1114     1115    +1     
  Misses                 1        1           
Flag Coverage Δ
unittests 99.91% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BrunoLiegiBastonLiegi BrunoLiegiBastonLiegi changed the title Numba threads tests Fixes for GPU tests and GPU workflow Jan 30, 2025
@andrea-pasquale andrea-pasquale added run-on-sim Launch tests on gpu and removed run-on-sim Launch tests on gpu labels Jan 31, 2025
@andrea-pasquale
Copy link
Contributor

@BrunoLiegiBastonLiegi is there something else that needs to be done to use the selfhosted workflow in this PR after dd5bfc0?
Currently it seems to be stuck https://github.com/qiboteam/qibojit/actions/runs/13069296398/job/36467252400?pr=200

@BrunoLiegiBastonLiegi
Copy link
Contributor Author

BrunoLiegiBastonLiegi commented Jan 31, 2025

Not 100% sure, but probably there are actions that need to be taken at the repo level, for instance I am not sure whether this secret:

repo_token: ${{ secrets.GITHUB_TOKEN }}

is available in this repo as well (@scarrazza )

@BrunoLiegiBastonLiegi BrunoLiegiBastonLiegi changed the base branch from main to cupy_matrices January 31, 2025 09:04
@scarrazza
Copy link
Member

scarrazza commented Jan 31, 2025

I think we can remove this secret.

@BrunoLiegiBastonLiegi BrunoLiegiBastonLiegi marked this pull request as ready for review January 31, 2025 09:59
@BrunoLiegiBastonLiegi
Copy link
Contributor Author

@andrea-pasquale I think we can merge this one in the meantime, such that I can update the pyproject of the qibo PR. We will address the secret problem and any other related issue directly in #199 if you agree.

@BrunoLiegiBastonLiegi BrunoLiegiBastonLiegi merged commit 8302937 into cupy_matrices Jan 31, 2025
29 of 31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
run-on-sim Launch tests on gpu
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants