-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cupy matrices #199
base: main
Are you sure you want to change the base?
Cupy matrices #199
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #199 +/- ##
=======================================
Coverage 99.91% 99.91%
=======================================
Files 12 12
Lines 1115 1116 +1
=======================================
+ Hits 1114 1115 +1
Misses 1 1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Fixes for GPU tests and GPU workflow
Before I forget it would be nice to modify these lines qibojit/src/qibojit/tests/test_backends.py Lines 122 to 124 in 8302937
whenever I test locally I need to edit them. Do you think that we can add some try-except blocks to check which gpu backends are available?
|
yeah, definitely. |
This attempts to reintroduce the cupy matrices as default for the cupy backend, as discussed in #196. It also fixes a bunch of other tests that were failing with
cupy
.edit: The tests seem to run fine on my local GPU, however I had to implement a maybe redundant class
CustomCupyMatrices
, which may be unnecessary under a more suitable inheritance chain of the matrices defined insidebackends,matrices.py