Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First small fix to math rendering in quantum_info #755

Closed
wants to merge 1 commit into from

Conversation

MatteoRobbiati
Copy link
Contributor

While reading the new documentation (I was having a look at the gradients' section), I noticed that the rendering of docstrings (especially regarding formulas and bra/ket notation) is not shown correctly in the quantum information paragraph. An example here.

I open this PR for fixing this.
I did a little small fix, but since the work is not mine, to avoid making mistakes, it's best for you @renatomello to take a look at it. I apologize if what I say is obvious, but perhaps using |state \rangle ( $|state\rangle$ ) can help solve part of the problem.

Thanks for the work and sorry for the intrusion.

@MatteoRobbiati MatteoRobbiati added the documentation Improvements or additions to documentation label Dec 30, 2022
@codecov
Copy link

codecov bot commented Dec 30, 2022

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage 👍

Coverage data is based on head (b9eb800) compared to base (716c96c).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #755   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           94        94           
  Lines        12392     12392           
=========================================
  Hits         12392     12392           
Flag Coverage Δ
unittests 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/qibo/quantum_info/basis.py 100.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@renatomello
Copy link
Contributor

renatomello commented Dec 30, 2022

I already implemented these and other documentation fixes in #743 , just waiting for approval to merge.

@MatteoRobbiati
Copy link
Contributor Author

I already implemented these and other documentation fixes in #743 , just waiting for approval to merge.

Oh, I am sorry.
So I will close this.

@scarrazza scarrazza deleted the fix-math-rendering branch January 23, 2023 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants