-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
unvectorization function #743
Conversation
This closes #738 . I generalized the |
Codecov ReportBase: 100.00% // Head: 100.00% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #743 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 94 94
Lines 12390 12439 +49
=========================================
+ Hits 12390 12439 +49
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Now there's an implementation of |
@renatomello thank you, looks good to me. @stavros11 could you please double check before we merge? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@renatomello thank you, looks good to me. @stavros11 could you please double check before we merge?
Yes, looks good to me and tests are passing including GPU. I think we can merge, thanks.
Checklist: