Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unvectorization function #743

Merged
merged 12 commits into from
Jan 2, 2023
Merged

unvectorization function #743

merged 12 commits into from
Jan 2, 2023

Conversation

renatomello
Copy link
Contributor

Checklist:

  • Reviewers confirm new code works as expected.
  • Tests are passing.
  • Coverage does not decrease.
  • Documentation is updated.

@renatomello renatomello added the enhancement New feature or request label Dec 25, 2022
@renatomello renatomello self-assigned this Dec 25, 2022
@renatomello renatomello linked an issue Dec 25, 2022 that may be closed by this pull request
@renatomello
Copy link
Contributor Author

renatomello commented Dec 25, 2022

This closes #738 . I generalized the vectorization function to include row- and column-wise vectorization, and created an unvectorization function for these two methods. For now, system-wise unvectorization is raising NotImplementedError.

@renatomello renatomello added this to the Qibo 0.1.10 milestone Dec 25, 2022
@codecov
Copy link

codecov bot commented Dec 25, 2022

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage 👍

Coverage data is based on head (840d3ca) compared to base (9788edf).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #743   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           94        94           
  Lines        12390     12439   +49     
=========================================
+ Hits         12390     12439   +49     
Flag Coverage Δ
unittests 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/qibo/quantum_info/basis.py 100.00% <100.00%> (ø)
src/qibo/tests/test_quantum_info_basis.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@renatomello
Copy link
Contributor Author

This closes #738 . I generalized the vectorization function to include row- and column-wise vectorization, and created an unvectorization function for these two methods. For now, system-wise unvectorization is raising NotImplementedError.

Now there's an implementation of unvectorization(order="system") thanks to Raghav.

@scarrazza
Copy link
Member

@renatomello thank you, looks good to me. @stavros11 could you please double check before we merge?

Copy link
Member

@stavros11 stavros11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@renatomello thank you, looks good to me. @stavros11 could you please double check before we merge?

Yes, looks good to me and tests are passing including GPU. I think we can merge, thanks.

@scarrazza scarrazza merged commit 0fcfbd3 into master Jan 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

unvectorization function
4 participants