Examples grover #389

AdrianPerezSalinas · 2021-04-19T14:04:19Z

Merging over grovermodel

renaming cma function

removing undesired prints

codecov · 2021-04-19T14:36:48Z

Codecov Report

Merging #389 (2f9f151) into grovermodel (6681af2) will not change coverage.
The diff coverage is 100.00%.

@@              Coverage Diff              @@
##           grovermodel      #389   +/-   ##
=============================================
  Coverage       100.00%   100.00%           
=============================================
  Files               79        80    +1     
  Lines            12689     12731   +42     
=============================================
+ Hits             12689     12731   +42

Flag	Coverage Δ
unittests	`100.00% <100.00%> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
src/qibo/core/gates.py	`100.00% <ø> (ø)`
...qibo/tests_new/test_tensorflow_custom_operators.py	`100.00% <ø> (ø)`
src/qibo/__init__.py	`100.00% <100.00%> (ø)`
src/qibo/optimizers.py	`100.00% <100.00%> (ø)`
src/qibo/tests_new/test_prints.py	`100.00% <100.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6681af2...2f9f151. Read the comment docs.

scarrazza · 2021-04-20T10:33:28Z

@AdrianPerezSalinas thanks for this. I have noticed that the sphinx documentation is not rendering properly, could you please have a look?

scarrazza · 2021-04-21T07:40:50Z

examples/grover/README.md

@@ -0,0 +1,123 @@
+# A General Grover Model
+
+This examples provide information to run a general Grover model accesible as


These / or better "The examples presented here..."

scarrazza · 2021-04-21T07:41:33Z

examples/grover/README.md

+
+- oracle (`qibo.core.circuit.Circuit`): quantum circuit that flips
+    the sign using a Grover ancilla initialized with -X-H-. Grover ancilla
+    expected to be last qubit of oracle circuit.


scarrazza · 2021-04-21T07:42:26Z

examples/grover/README.md

+    The found bitstring not included.
+- iterative (bool): force the use of the iterative Grover
+
+We provide three different examples to run Grover with


scarrazza · 2021-04-21T07:43:16Z

examples/grover/README.md

+In this first example we show how to use a standard Grover search where the
+search space is an equally weighted superposition of quantum states and the oracle
+is simply defined through a layer of Hadamard gates. This example makes no use of 
+ancilla qubits, so the syntaxis simplifies greatly. 


the syntax, or the command lines / function calls?

scarrazza · 2021-04-21T07:44:14Z

examples/grover/README.md

+
+### Example 3: Ancillas for superposition and oracle, setting size of search space
+
+In this third example we create a Grover model with two components


components:

scarrazza · 2021-04-21T07:44:28Z

examples/grover/example_1.py

@@ -0,0 +1,21 @@
+


remove empty line

scarrazza · 2021-04-21T07:45:07Z

examples/grover/example_1.py

+solution, iterations = grover()
+
+print('The solution is', solution)
+print('Number of iterations needed:', iterations)


add empty line.

scarrazza

Thanks for this implementation, I have included some comments above, in general however would be great if you could convert the file to PEP8 convetion and include these files in test_examples.py.

fixing hep import in sphinx

Test that code does not contain `print` statements

AdrianPerezSalinas · 2021-04-22T18:14:48Z

Hi @scarrazza ,

I think everything is fixed now, please let me know if there is anything wrong

This reverts commit cbb846e.

This reverts commit 05332bc.

scarrazza · 2021-04-26T09:30:54Z

examples/grover/1/main.py

+
+if __name__ == "__main__":
+    parser = argparse.ArgumentParser()
+    parser.add_argument("--qubits", default=5, type=int)


@AdrianPerezSalinas this example is not working for me, it crashes at line 20.
Could you please rename qubits in nqubits in order to match the syntax of other examples?

Does the problem come from this mismatch? I have tested it and it works

How is the test_examples.py file run? I cannot see it clearly and I think here is where the problem lies

scarrazza · 2021-04-26T09:31:35Z

examples/grover/README.md

@@ -0,0 +1,123 @@
+# A General Grover Model
+


Please include a reference link to the code, as we do in all tutorials.

scarrazza

Let me suggest to move the examples to:

example1.py
example2.py
example3.py

…amples_grover

scarrazza and others added 8 commits April 12, 2021 13:51

updating version

395dac0

updating version to 0.1.5-dev

cbb846e

rename cma to cmaes function

f2b702f

adding missing import for cma options

78314bc

Merge pull request #383 from Quantum-TII/cmaesrename

db9b794

renaming cma function

removing undesired prints

acb855c

Merge pull request #387 from Quantum-TII/fixprints

c9a2043

removing undesired prints

examples added

3ed3c07

scarrazza changed the base branch from master to grovermodel April 19, 2021 14:18

adding example to sphinx

f1ba339

scarrazza and others added 4 commits April 20, 2021 12:34

fixing hep import in sphinx

8871102

Add test that checks if code contains prints

e2deda5

Fix windows tests

2cba063

Fix coverage

6652be9

scarrazza reviewed Apr 21, 2021

View reviewed changes

examples/grover/example_1.py Outdated

@@ -0,0 +1,21 @@

Copy link

Member

scarrazza Apr 21, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove empty line

scarrazza reviewed Apr 21, 2021

View reviewed changes

scarrazza requested changes Apr 21, 2021

View reviewed changes

scarrazza and others added 3 commits April 21, 2021 12:13

Merge pull request #390 from Quantum-TII/fixhep

ce55a14

fixing hep import in sphinx

Merge pull request #391 from Quantum-TII/testprint

566cff6

Test that code does not contain `print` statements

format fixed, tests, README

8c8c22c

scarrazza added 2 commits April 22, 2021 23:48

Revert "updating version to 0.1.5-dev"

05332bc

This reverts commit cbb846e.

Revert "Revert "updating version to 0.1.5-dev""

e053e3e

This reverts commit 05332bc.

scarrazza added 3 commits April 22, 2021 23:51

updating version for release

cc8cfab

updating dev version

53ec3d2

Merge branch 'master' into examples_grover

8f497ac

scarrazza reviewed Apr 26, 2021

View reviewed changes

AdrianPerezSalinas and others added 8 commits April 26, 2021 12:51

rename, fix typos, added link

ff27d11

added new line to enf of file

ff8efa2

Merge branch 'examples_grover' of github.com:Quantum-TII/qibo into ex…

6f72bff

…amples_grover

added newlines

80035eb

Merge branch 'examples_grover' of github.com:Quantum-TII/qibo into ex…

9330375

…amples_grover

fixing tests

b514d37

updating docs / fixing typos

4f23918

adjusting examples

2f9f151

scarrazza merged commit a7da4d1 into grovermodel Apr 26, 2021

delete-merged-branch bot deleted the examples_grover branch April 26, 2021 17:56

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Examples grover #389

Examples grover #389

AdrianPerezSalinas commented Apr 19, 2021

codecov bot commented Apr 19, 2021 •

edited

Loading

scarrazza commented Apr 20, 2021

scarrazza Apr 21, 2021

scarrazza Apr 21, 2021

scarrazza Apr 21, 2021

scarrazza Apr 21, 2021

scarrazza Apr 21, 2021

scarrazza Apr 21, 2021

scarrazza Apr 21, 2021

scarrazza left a comment

AdrianPerezSalinas commented Apr 22, 2021

scarrazza Apr 26, 2021

AdrianPerezSalinas Apr 26, 2021

AdrianPerezSalinas Apr 26, 2021

scarrazza Apr 26, 2021

AdrianPerezSalinas Apr 26, 2021

scarrazza left a comment

		@@ -0,0 +1,123 @@
		# A General Grover Model

		This examples provide information to run a general Grover model accesible as


		### Example 3: Ancillas for superposition and oracle, setting size of search space

		In this third example we create a Grover model with two components

Examples grover #389

Examples grover #389

Conversation

AdrianPerezSalinas commented Apr 19, 2021

codecov bot commented Apr 19, 2021 • edited Loading

Codecov Report

scarrazza commented Apr 20, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

scarrazza left a comment

Choose a reason for hiding this comment

AdrianPerezSalinas commented Apr 22, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

scarrazza left a comment

Choose a reason for hiding this comment

codecov bot commented Apr 19, 2021 •

edited

Loading