Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

renaming cma function #383

Merged
merged 2 commits into from
Apr 13, 2021
Merged

renaming cma function #383

merged 2 commits into from
Apr 13, 2021

Conversation

scarrazza
Copy link
Member

Closes #381. @DiegoGM91 could you please confirm this solves the ambiguity?

@scarrazza scarrazza requested a review from DiegoGM91 April 13, 2021 09:21
@codecov
Copy link

codecov bot commented Apr 13, 2021

Codecov Report

Merging #383 (78314bc) into master (cbb846e) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##            master      #383    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files           77        77            
  Lines        12454     12196   -258     
==========================================
- Hits         12454     12196   -258     
Flag Coverage Δ
unittests 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/qibo/optimizers.py 100.00% <100.00%> (ø)
src/qibo/solvers.py 100.00% <0.00%> (ø)
src/qibo/core/gates.py 100.00% <0.00%> (ø)
src/qibo/core/states.py 100.00% <0.00%> (ø)
src/qibo/core/circuit.py 100.00% <0.00%> (ø)
src/qibo/core/callbacks.py 100.00% <0.00%> (ø)
src/qibo/models/circuit.py 100.00% <0.00%> (ø)
src/qibo/tests/test_hep.py 100.00% <0.00%> (ø)
src/qibo/tests/test_qft.py 100.00% <0.00%> (ø)
src/qibo/backends/einsum.py 100.00% <0.00%> (ø)
... and 39 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cbb846e...78314bc. Read the comment docs.

Copy link
Contributor

@DiegoGM91 DiegoGM91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@scarrazza this removes the ambiguity, yes.

But I still think that a sentence in the documentation may be in place, e.g. saying that one first needs to import cma to be able to see the CMAOptions.

@scarrazza scarrazza merged commit db9b794 into master Apr 13, 2021
@delete-merged-branch delete-merged-branch bot deleted the cmaesrename branch April 13, 2021 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Optimizers documentation
2 participants