Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: turn on test no fastembed #522

Merged
merged 3 commits into from
Mar 4, 2024
Merged

fix: turn on test no fastembed #522

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c520230
fix: turn on test no fastembed
joein Mar 3, 2024
984225e
fix: ignore input
joein Mar 3, 2024
680b4df
Update fastembed tests job name
joein Mar 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .github/workflows/integration-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,11 @@ jobs:
export RUNNER_OS=${{ runner.os }}
QDRANT_VERSION='v1.7.4' ./tests/integration-tests.sh
shell: bash
- name: Run fastembed tests without fastembed
run: |
pip3 uninstall fastembed -y
pytest tests/test_fastembed.py
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should create a directory for fastembed tests. We may add more files, and with a dedicated directory we won't need to update this script

Copy link
Member Author

@joein joein Mar 4, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest putting off creating a separate directory until we need it

shell: bash
- name: Check conversion coverage
run: |
export RUNNER_OS=${{ runner.os }}
Expand Down
0 tests/test_fast_embed.py → tests/test_fastembed.py
View file
Open in desktop
File renamed without changes.
Loading