fix: turn on test no fastembed #522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for poetic-froyo-8baba7 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
coszio
requested changes
Mar 4, 2024
| - name: Fastembed not installed tests | ||
| run: | | ||
| pip3 uninstall fastembed -y | ||
| pytest tests/test_fastembed.py |
There was a problem hiding this comment.
I think we should create a directory for fastembed tests. We may add more files, and with a dedicated directory we won't need to update this script
There was a problem hiding this comment.
I suggest putting off creating a separate directory until we need it
Co-authored-by: Luis Cossío <[email protected]>
coszio
approved these changes
Mar 4, 2024
joein
added a commit
that referenced
this pull request
Mar 5, 2024
* fix: turn on test no fastembed * fix: ignore input * Update fastembed tests job name Co-authored-by: Luis Cossío <[email protected]> --------- Co-authored-by: Luis Cossío <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.