Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove deprecated field conversions #502

Merged
merged 1 commit into from
Mar 1, 2024
Merged

remove deprecated field conversions #502

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 0 additions & 10 deletions qdrant_client/conversions/conversion.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1120,9 +1120,6 @@ def convert_points_update_operation(
shard_key=shard_key_selector,
)
)
# TODO: remove deprecated field in v1.8.0
elif name == "delete_deprecated":
return rest.DeleteOperation(delete=cls.convert_points_selector(val))
elif name == "delete_points":
shard_key_selector = (
val.shard_key_selector if val.HasField("shard_key_selector") else None
Expand Down Expand Up @@ -1206,9 +1203,6 @@ def convert_points_update_operation(
filter=filter_,
)
)
# TODO: remove deprecated field in v1.8.0
elif name == "clear_payload_deprecated":
return rest.ClearPayloadOperation(clear_payload=cls.convert_points_selector(val))
elif name == "clear_payload":
shard_key_selector = (
val.shard_key_selector if val.HasField("shard_key_selector") else None
Expand Down Expand Up @@ -2527,8 +2521,6 @@ def convert_points_update_operation(
)
return grpc.PointsUpdateOperation(
delete_points=delete_points,
# TODO: remove deprecated field in v1.8.0
delete_deprecated=points_selector,
)
elif isinstance(model, rest.SetPayloadOperation):
if model.set_payload.points:
Expand Down Expand Up @@ -2610,8 +2602,6 @@ def convert_points_update_operation(
)
return grpc.PointsUpdateOperation(
clear_payload=clear_payload,
# TODO: remove deprecated field in v1.8.0
clear_payload_deprecated=points_selector,
)
elif isinstance(model, rest.UpdateVectorsOperation):
shard_key_selector = (
Expand Down
8 changes: 0 additions & 8 deletions tests/conversions/fixtures.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -756,14 +756,10 @@

delete_operation_1 = grpc.PointsUpdateOperation(
delete_points=grpc.PointsUpdateOperation.DeletePoints(points=points_selector_list),
# TODO: remove deprecated field in v1.8.0
delete_deprecated=points_selector_list,
)

delete_operation_2 = grpc.PointsUpdateOperation(
delete_points=grpc.PointsUpdateOperation.DeletePoints(points=points_selector_filter),
# TODO: remove deprecated field in v1.8.0
delete_deprecated=points_selector_filter,
)

set_payload_operation_1 = grpc.PointsUpdateOperation(
Expand Down Expand Up @@ -810,14 +806,10 @@

clear_payload_operation_1 = grpc.PointsUpdateOperation(
clear_payload=grpc.PointsUpdateOperation.ClearPayload(points=points_selector_list),
# TODO: remove deprecated field in v1.8.0
clear_payload_deprecated=points_selector_list,
)

clear_payload_operation_2 = grpc.PointsUpdateOperation(
clear_payload=grpc.PointsUpdateOperation.ClearPayload(points=points_selector_filter),
# TODO: remove deprecated field in v1.8.0
clear_payload_deprecated=points_selector_filter,
)

update_vectors_operation = grpc.PointsUpdateOperation(
Expand Down
Loading