Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove deprecated field conversions #502

Merged
merged 1 commit into from
Mar 1, 2024

Conversation

coszio
Copy link
Contributor

@coszio coszio commented Feb 21, 2024

For client Qdrant 1.8, we no longer need to support both deprecated and undeprecated fields, so this PRs removes these extra conversions.

All Submissions:

  • Contributions should target the dev branch. Did you create your branch from dev?
  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  1. Does your submission pass tests?
  2. Have you installed pre-commit with pip3 install pre-commit and set up hooks with pre-commit install?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@coszio coszio requested a review from joein February 21, 2024 16:37
Copy link

netlify bot commented Feb 21, 2024

Deploy Preview for poetic-froyo-8baba7 ready!

Name Link
🔨 Latest commit 20d3bd0
🔍 Latest deploy log https://app.netlify.com/sites/poetic-froyo-8baba7/deploys/65e1f856a7f5370008ee7415
😎 Deploy Preview https://deploy-preview-502--poetic-froyo-8baba7.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@generall generall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM on green CI

@coszio coszio force-pushed the remove-deprecated-proto-field-conversions branch from e21bd68 to 20d3bd0 Compare March 1, 2024 15:46
@coszio coszio merged commit 09d51e6 into dev Mar 1, 2024
14 checks passed
joein pushed a commit that referenced this pull request Mar 5, 2024
@generall generall deleted the remove-deprecated-proto-field-conversions branch May 3, 2024 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants