add support aliyun dns

[cnjack]

No description provided.

[cnjack]

can you help me review my code? @qdm12

[qdm12]

Thanks for the PR! Just a few minor comments to fix up and I'll merge it.

Have you had the change to test run it? Let me know if you need help building the Docker image.

EDIT: I'm away until Tuesday so I might be not answering until then!

[qdm12]

Would this create the domain record if it doesn't exist? Also what's the first element returned, the response? It might be worth checking what's in there.

[cnjack]

I think user need create the domain by themself, we needn't do create action. if recordID not found, it will return errors.ErrRecordNotFound

[cnjack]

1. use DescribeDomainRecords check if this domain existed under this clients and get the recordID.
2. use recordID update the domain's IP

[qdm12]

Yes I know, it's just there is #129 that I'm working on for all providers.

It's fine, I'll take care of it at a later time if it's not trivial to implement.

[cnjack]

great, I will follow your action. let me handle it for this provider.

[cnjack]

thanks for your review, I have pushed image in my personal account, and test it in my NAS

[cnjack]

hi @qdm12 , have you came back? can you help me review my code?

[qdm12]

Thanks @cnjack for the fixes! Just a tiny suggestion to commit in the docs/aliyun.md and I'll merge it!

[cnjack]

Thanks @cnjack for the fixes! Just a tiny suggestion to commit in the docs/aliyun.md and I'll merge it!

updated the document, thanks for your job

[qdm12]

Hey @cnjack

I reworked the Aliyun code in 8a14828 to have no SDK dependency and only do http calls to their API directly. The Docker image is available qmcgaw/ddns-updater:aliyun-nosdk, could you try it sometime? Thanks!

[cnjack]

No problem, I will try it.