Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SLSTR angle interpolation. #3017

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Fix SLSTR angle interpolation.

8bb668a
Select commit
Loading
Failed to load commit list.
Open

Fix SLSTR angle interpolation. #3017

Fix SLSTR angle interpolation.
8bb668a
Select commit
Loading
Failed to load commit list.
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main) succeeded Dec 13, 2024 in 32s

CodeScene PR Check

✅ Code Health Quality Gates: OK

Change in average Code Health of affected files: -0.31 (9.84 -> 9.54)

  • Declining Code Health: 1 findings(s) 🚩

View detailed results in CodeScene

Details

🚩 Declining Code Health (highest to lowest):

  • Complex Method slstr_l1b.py: NCSLSTRAngles.get_dataset

Annotations

Check warning on line 325 in satpy/readers/slstr_l1b.py

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Complex Method 

NCSLSTRAngles.get_dataset has a cyclomatic complexity of 10, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.
View more details on CodeScene Delta Analysis