Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SLSTR angle interpolation. #3017

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

simonrp84
Copy link
Member

This PR adds a new method for interpolating angles from the SLSTR tie grid, which should prevent the unrealistically low and/or high values that sometimes showed up before, primarily in granules near the poles.

@simonrp84 simonrp84 requested a review from mraspaud as a code owner December 13, 2024 21:03
Copy link

codecov bot commented Dec 13, 2024

Codecov Report

Attention: Patch coverage is 27.27273% with 8 lines in your changes missing coverage. Please review.

Project coverage is 96.08%. Comparing base (5984c29) to head (8bb668a).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
satpy/readers/slstr_l1b.py 27.27% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3017      +/-   ##
==========================================
- Coverage   96.10%   96.08%   -0.02%     
==========================================
  Files         377      377              
  Lines       55163    55172       +9     
==========================================
+ Hits        53012    53013       +1     
- Misses       2151     2159       +8     
Flag Coverage Δ
behaviourtests 3.94% <0.00%> (-0.01%) ⬇️
unittests 96.18% <27.27%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 12322983456

Details

  • 3 of 11 (27.27%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.01%) to 96.193%

Changes Missing Coverage Covered Lines Changed/Added Lines %
satpy/readers/slstr_l1b.py 3 11 27.27%
Totals Coverage Status
Change from base Build 12299617024: -0.01%
Covered Lines: 53257
Relevant Lines: 55365

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

extrapolation of satellite relative azimuiths?
2 participants