-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve documentation #99
Merged
+1,073
−679
Merged
Changes from 1 commit
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
9aad2d2
Add development options
sfinkens 0969f74
Update documentation
sfinkens 65ef72b
Compute times before using them
sfinkens 86ea22b
Add level1c4pps to list of related projects
sfinkens 3a101ed
Include inheritance diagram for readers
sfinkens 76dae92
Exclude abstract methods from coverage
sfinkens 51ff748
Revert "Exclude abstract methods from coverage"
sfinkens dfa6462
Exclude abstract methods from coverage
sfinkens b4b98d5
Merge branch 'main' into improve-docs
sfinkens 90501db
Update doc/source/methods.rst
sfinkens e40e5a2
Update doc/source/methods.rst
sfinkens 1d5b1ef
Add more calibration details
sfinkens 51d4dec
Add link to pre-commit webpage
sfinkens c789da4
Remove wrong statement about window size
sfinkens File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Update doc/source/methods.rst
Co-authored-by: Martin Raspaud <[email protected]>
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am a bit confused by the implementation of this factor, because it is introduced in https://github.com/pytroll/pygac/blob/main/pygac/reader.py#L510 and passed to the solar calibration, but there it raises a deprecation warning according to https://github.com/pytroll/pygac/blob/main/pygac/calibration.py#L334-L340.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Found this one: #58 (comment) Looks like a future reminder