Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve documentation #99

Merged
merged 14 commits into from
Jan 4, 2022
Prev Previous commit
Next Next commit
Update doc/source/methods.rst
Co-authored-by: Martin Raspaud <[email protected]>
sfinkens and mraspaud authored Dec 6, 2021

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
commit 90501db80eb6cf88546fc365242706ca7f825b63
2 changes: 1 addition & 1 deletion doc/source/methods.rst
Original file line number Diff line number Diff line change
@@ -20,7 +20,7 @@ deriving fundamental climate data records.
The reflectances are normalized by a factor (as a function of day of a year)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am a bit confused by the implementation of this factor, because it is introduced in https://github.com/pytroll/pygac/blob/main/pygac/reader.py#L510 and passed to the solar calibration, but there it raises a deprecation warning according to https://github.com/pytroll/pygac/blob/main/pygac/calibration.py#L334-L340.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found this one: #58 (comment) Looks like a future reminder

to account for changing Earth-Sun distance. However, it is left to the
user to apply further normalization using cosine of solar zenith
angle (depending on application in question).
angle for example (depending on application in question).

The thermal channel intercalibration is done from scratch, starting from
obtaining Platinum Resistance Thermometer (PRT), space and Internal