Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve documentation #99

Merged
merged 14 commits into from
Jan 4, 2022
Merged

Improve documentation #99

merged 14 commits into from
Jan 4, 2022

Conversation

sfinkens
Copy link
Member

@sfinkens sfinkens commented Dec 6, 2021

Improve documentation:

  • Update installation instructions
  • Add usage examples
  • Move algorithm descriptions to a new "Methods" chapter
  • Move HDF description to a new "Legacy Output" chapter
  • Add more readers and an inheritance diagram to API chapter

You can preview the updated version here: https://sfinkens.github.io/

Along the way I also included dependencies for development in setup.py and fixed a minor bug in Reader.get_calibrated_channels (using timestamps before they are computed).

Closes #85, closes #43.

@sfinkens sfinkens self-assigned this Dec 6, 2021
@codecov
Copy link

codecov bot commented Dec 6, 2021

Codecov Report

Merging #99 (c789da4) into main (95cf613) will increase coverage by 2.76%.
The diff coverage is 91.22%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #99      +/-   ##
==========================================
+ Coverage   70.26%   73.02%   +2.76%     
==========================================
  Files          33       33              
  Lines        2795     2829      +34     
==========================================
+ Hits         1964     2066     +102     
+ Misses        831      763      -68     
Impacted Files Coverage Δ
pygac/klm_reader.py 59.39% <ø> (ø)
pygac/pod_reader.py 63.86% <ø> (ø)
pygac/tests/test_reader.py 98.27% <89.79%> (-1.39%) ⬇️
pygac/gac_klm.py 83.33% <100.00%> (ø)
pygac/gac_pod.py 83.33% <100.00%> (ø)
pygac/lac_pod.py 61.11% <100.00%> (ø)
pygac/reader.py 79.64% <100.00%> (+14.81%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 95cf613...c789da4. Read the comment docs.

@sfinkens sfinkens requested a review from carloshorn December 6, 2021 10:11
Copy link
Member

@mraspaud mraspaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for taking care of the documentation! Some small comments

doc/source/installation.rst Outdated Show resolved Hide resolved
doc/source/methods.rst Outdated Show resolved Hide resolved
doc/source/methods.rst Outdated Show resolved Hide resolved
doc/source/methods.rst Outdated Show resolved Hide resolved
Copy link
Collaborator

@ninahakansson ninahakansson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@carloshorn carloshorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care of documentation.


$> export PYTHONPATH=$PREFIX/lib/python2.7/site-packages:$PYTHONPATH
It is recommended to activate `pre-commit`_ checks.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, you started using pre-commit.

and follow the Global Climate Observing System (GCOS) standards for
deriving fundamental climate data records.

The reflectances are normalized by a factor (as a function of day of a year)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am a bit confused by the implementation of this factor, because it is introduced in https://github.com/pytroll/pygac/blob/main/pygac/reader.py#L510 and passed to the solar calibration, but there it raises a deprecation warning according to https://github.com/pytroll/pygac/blob/main/pygac/calibration.py#L334-L340.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found this one: #58 (comment) Looks like a future reminder

doc/source/methods.rst Outdated Show resolved Hide resolved
@sfinkens
Copy link
Member Author

Thanks for your review @carloshorn ! Very good to double check that the docs match the current implementation!

Copy link
Collaborator

@abhaydd abhaydd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent documentation, @sfinkens
I have gone through it and I have no comments.
Thanks a lot!

@sfinkens
Copy link
Member Author

sfinkens commented Jan 4, 2022

Thanks for taking the time @abhaydd!

@sfinkens sfinkens merged commit f23ecbd into pytroll:main Jan 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update documentation Links to POD/KLM user guides are broken
5 participants