Refactor generate_vbe_metadata #3087
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request was exported from Phabricator. Differential Revision: D62215222 |
✅ Deploy Preview for pytorch-fbgemm-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
This pull request was exported from Phabricator. Differential Revision: D62215222 |
sryap
force-pushed
the
export-D62215222
branch
from
346b59f
to
e747934
Compare
sryap
added a commit
to sryap/FBGEMM
that referenced
this pull request
Sep 6, 2024
Summary: Pull Request resolved: pytorch#3087 Moves `generate_vbe_metadata` into the `fbgemm_gpu.split_table_batched_embeddings_ops_training_common`. This is a preparation for VBE enablement in SSD-TBE Reviewed By: q10 Differential Revision: D62215222
sryap
added a commit
to sryap/FBGEMM
that referenced
this pull request
Sep 6, 2024
Summary: X-link: facebookresearch/FBGEMM#178 Pull Request resolved: pytorch#3087 Moves `generate_vbe_metadata` into the `fbgemm_gpu.split_table_batched_embeddings_ops_training_common`. This is a preparation for VBE enablement in SSD-TBE Reviewed By: q10 Differential Revision: D62215222
|
This pull request was exported from Phabricator. Differential Revision: D62215222 |
sryap
force-pushed
the
export-D62215222
branch
from
e747934
to
8be5ad7
Compare
|
This pull request was exported from Phabricator. Differential Revision: D62215222 |
sryap
added a commit
to sryap/FBGEMM
that referenced
this pull request
Sep 7, 2024
Summary: X-link: facebookresearch/FBGEMM#178 Pull Request resolved: pytorch#3087 Moves `generate_vbe_metadata` into the `fbgemm_gpu.split_table_batched_embeddings_ops_training_common`. This is a preparation for VBE enablement in SSD-TBE Reviewed By: q10 Differential Revision: D62215222
sryap
force-pushed
the
export-D62215222
branch
from
8be5ad7
to
451f6e3
Compare
Summary: X-link: facebookresearch/FBGEMM#178 Pull Request resolved: pytorch#3087 Moves `generate_vbe_metadata` into the `fbgemm_gpu.split_table_batched_embeddings_ops_training_common`. This is a preparation for VBE enablement in SSD-TBE Reviewed By: q10 Differential Revision: D62215222
|
This pull request was exported from Phabricator. Differential Revision: D62215222 |
sryap
force-pushed
the
export-D62215222
branch
from
451f6e3
to
4e060a2
Compare
|
This pull request has been merged in adb9d0f. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Moves
generate_vbe_metadatainto thefbgemm_gpu.split_table_batched_embeddings_ops_training_common. Thisis a preparation for VBE enablement in SSD-TBE
Reviewed By: q10
Differential Revision: D62215222