Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

attach eviction filling logic to set_cache #3034

Closed
wants to merge 3 commits into from

Commits on Aug 29, 2024

  1. add ods logging for l2 cache perf (pytorch#3031)

    Summary:
    X-link: pytorch/torchrec#2335
    
    Pull Request resolved: pytorch#3031
    
    X-link: facebookresearch/FBGEMM#129
    
    collect performance related metrics from KV store and export them to ODS
    
    Differential Revision: D61417980
    Guanqiao Wang authored and facebook-github-bot committed Aug 29, 2024
    Configuration menu
    Copy the full SHA
    f3b2a2e View commit details
    Browse the repository at this point in the history

Commits on Aug 30, 2024

  1. move set_cache and set_async to background thread

    Summary:
    set cache is inserting values into L2 cache
    set_async it inserting values into SSD(rocksdb)
    
    this 2 steps could be done asynchronously in the background thread wihtout blocking the read path.
    Actually, it could potentially block the next read if it take close to each train iteration time.
    
    Differential Revision: D61418016
    Guanqiao Wang authored and facebook-github-bot committed Aug 30, 2024
    Configuration menu
    Copy the full SHA
    84ba50d View commit details
    Browse the repository at this point in the history

Commits on Sep 1, 2024

  1. attach eviction filling logic to set_cache

    Summary:
    X-link: facebookresearch/FBGEMM#132
    
    - add eviction callback into cachelib
    - add eviction handling logic in cachelib wrapper and kv db tbe
    
    Differential Revision: D61200308
    Joe Wang authored and facebook-github-bot committed Sep 1, 2024
    Configuration menu
    Copy the full SHA
    08a5b4d View commit details
    Browse the repository at this point in the history