attach eviction filling logic to set_cache #3034
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request was exported from Phabricator. Differential Revision: D61200308 |
✅ Deploy Preview for pytorch-fbgemm-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Summary: X-link: pytorch/torchrec#2335 Pull Request resolved: pytorch#3031 X-link: facebookresearch/FBGEMM#129 collect performance related metrics from KV store and export them to ODS Differential Revision: D61417980
Summary: set cache is inserting values into L2 cache set_async it inserting values into SSD(rocksdb) this 2 steps could be done asynchronously in the background thread wihtout blocking the read path. Actually, it could potentially block the next read if it take close to each train iteration time. Differential Revision: D61418016
Summary: X-link: facebookresearch/FBGEMM#132 - add eviction callback into cachelib - add eviction handling logic in cachelib wrapper and kv db tbe Differential Revision: D61200308
|
This pull request was exported from Phabricator. Differential Revision: D61200308 |
duduyi2013
force-pushed
the
export-D61200308
branch
from
f6e6cc1
to
08a5b4d
Compare
|
This pull request has been merged in 8346a7d. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Differential Revision: D61200308