-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reformatted all files with black and isort #4224
Conversation
A few comments between imports were removed or moved to the top of the import block, due to behavioral differences between black and isort. See psf/black#251 for details. In two instances @Overloads at the top of the file needed to be moved due to psf/black#1490.
Now pytype fails. It was fine with the previous commit, but bails when moving the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Feel free to merge this as soon as CI passes.
Were you able to figure out what exactly pytype is choking on? It seems to be reporting errors for files that import the broken file, since some of the files that it complains about in CI have only whitespace changes. The problem looks to be somewhere in asyncio but I haven't been able to find out which file exactly.
The problem is only with the second commit, which only touches three files. I will see whether I can work around this later. |
Sorry, just saw this. At a glance, it looks like pytype doesn't expect a |
For python/typeshed#4224. We really need a better pyi parser... PiperOrigin-RevId: 316171517
I pushed a pytype change to allow |
Closing. I will open a new PR when the new pytest version is released. In the meantime, #4228 contains a few changes from this PR to address black and isort incompatibilities that will ease the Big Reformat. |
Looks like the pytype release hasn't gone out just yet. |
A few comments between imports were removed or moved to the top of the
import block, due to behavioral differences between black and isort. See
psf/black#251 for details.
In two instances
@overloads
at the top of the file needed to be moveddue to psf/black#1490.