Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Release for fixes required for typeshed's Big Reformat? #608

Closed
srittau opened this issue Jun 26, 2020 · 2 comments
Closed

New Release for fixes required for typeshed's Big Reformat? #608

srittau opened this issue Jun 26, 2020 · 2 comments
Assignees

Comments

@srittau
Copy link
Contributor

srittau commented Jun 26, 2020

Is it possible to cut a new release that incorporates the fixes to pytype's parser required for typeshed's Big Reformat? See python/typeshed#4224 for details.

@rchen152
Copy link
Contributor

Ah sorry, this slipped my mind. I'll try to get a release out today.

@rchen152 rchen152 self-assigned this Jun 26, 2020
rchen152 added a commit that referenced this issue Jun 26, 2020
For #608.

I fixed a pyi parser issue about two weeks ago, and we need to do a release so
that typeshed can use the fix.

I don't feel confident releasing at head (too many findings to click through to
check if there are any new crashes, obvious bugs, etc.), so what I plan to do
is to temporarily roll back the change that generates the vast majority of the
new findings, release on PyPI, and then reapply that change.

PiperOrigin-RevId: 318522426
@rchen152
Copy link
Contributor

Ok, pytype 2020.06.26 is out. I checked that it can successfully analyze all of the files in typeshed/stdlib after running black on them and that it's also happy with the changes in python/typeshed@a6d73ac (applied to the master branch).

rchen152 added a commit that referenced this issue Jun 29, 2020
*** Reason for rollback ***

The PyPI release is out, so revert temporary changes made for the release.

*** Original change description ***

Do a PyPI release for a parser fix.

For #608.

I fixed a pyi parser issue about two weeks ago, and we need to do a release so
that typeshed can use the fix.

I don't feel confident releasing at head (too many findings to click through to
check if there are any new crashes, obvious bugs, etc.), so what I plan to do
is to temporarily roll back the change that generates the vast majority of the
new findings, release on PyPI, and then reapply that change.

***

PiperOrigin-RevId: 318553012
@rchen152 rchen152 closed this as completed Jul 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants