Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PEP 404: Add Python 2.8 to Release PEPs topic #2986

Merged
merged 1 commit into from
Jan 31, 2023

Conversation

hugovk
Copy link
Member

@hugovk hugovk commented Jan 30, 2023

Follow on to #2669.

Add PEP 404 ("Python 2.8 Un-release Schedule") to the Release topic.

It's an un-release schedule for a 404 version-not-found :) but probably belongs in the topic.

Copy link
Member

@warsaw warsaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, with questions: should info collection include a test on Topic? I haven't been following the addition of this header, and can't check atm, but has this header been added to PEP 101?

@hugovk
Copy link
Member Author

hugovk commented Jan 30, 2023

Approved, with questions: should info collection include a test on Topic?

If I understand the question properly: no, there are lots of informational PEPs, and only a small handful are in any topics.

I haven't been following the addition of this header, and can't check atm, but has this header been added to PEP 101?

It hasn't. (This "Release" topic was added in #2669, and support for topic headers was added in #2579.)

I don't think it needs to be in the release checklist, as it's something to check when the new release PEP is created, not an actual release.

Plus I expect release managers will copy/paste the last release PEP for the next one.

@warsaw
Copy link
Member

warsaw commented Jan 30, 2023

has this header been added to PEP 101

Oops! I meant PEP 1! I think Topic should be added to PEP 1 and PEP 12.

Copy link
Member

@CAM-Gerlach CAM-Gerlach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @hugovk !

@hugovk
Copy link
Member Author

hugovk commented Jan 31, 2023

has this header been added to PEP 101

Oops! I meant PEP 1! I think Topic should be added to PEP 1 and PEP 12.

Good idea, I'll open another PR for that :)

@hugovk hugovk merged commit 77bbe79 into python:main Jan 31, 2023
@hugovk hugovk deleted the add-2.8-to-release-topic branch January 31, 2023 09:03
@hugovk
Copy link
Member Author

hugovk commented Jan 31, 2023

Please see PR #2995 to document the Topic header in PEPs 1 and 12.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants