Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Topic for release schedule PEPs #2669

Merged
merged 11 commits into from
Oct 7, 2022

Conversation

JelleZijlstra
Copy link
Member

Release PEPs are a pretty unusual kind of PEP and it's useful to me to have
them all listed together. Happy to adjust the name of the topic if desired.

I took the opportunity to adjust the status of a few release PEPs. Now all
releases for EOL versions are Final (3.5 was previously Active), and all
releases for released versions are Active (3.10 was still draft). 3.11 remains
Draft as 3.11 has not yet been released.

Release PEPs are a pretty unusual kind of PEP and it's useful to me to have
them all listed together. Happy to adjust the name of the topic if desired.

I took the opportunity to adjust the status of a few release PEPs. Now all
releases for EOL versions are Final (3.5 was previously Active), and all
releases for released versions are Active (3.10 was still draft). 3.11 remains
Draft as 3.11 has not yet been released.
@hugovk
Copy link
Member

hugovk commented Jun 25, 2022

This would be useful.

Preview: https://pep-previews--2669.org.readthedocs.build/topic/releases/

Please also include PEP 693 for Python 3.12.

@AA-Turner
Copy link
Member

Happy to adjust the name of the topic if desired.

"Release Schedule" would make sense to me, spaces are allowed within the topic names.

A

Copy link
Member

@AA-Turner AA-Turner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also add PEP-160, PEP-200, PEP-226, PEP-251, PEP-283, PEP-320, and PEP-356

A

pep_sphinx_extensions/pep_zero_generator/constants.py Outdated Show resolved Hide resolved
pep_sphinx_extensions/pep_zero_generator/constants.py Outdated Show resolved Hide resolved
pep_sphinx_extensions/pep_zero_generator/constants.py Outdated Show resolved Hide resolved
@CAM-Gerlach
Copy link
Member

CAM-Gerlach commented Jun 27, 2022

"Release Schedule" would make sense to me, spaces are allowed within the topic names.

But then the URL to the topic page wouldn't match the lowercase/case insensitive topic name; either it would have to have _, - inserted or escape codes inserted, and the same for the generated rst file name. It's also extra words, and the "Releases" PEP isn't just a schedule, it also lists the features of the release, crew, and other details.

@pradyunsg
Copy link
Member

My 2 cents: "Release Schedule" or "Release" are better names since they'll read better in the page heading ("Release Schedule PEPs"/"Release PEPs"). Right now, it looks to me like there's a grammatical error in there.

@pradyunsg
Copy link
Member

It might also make sense to retitle "Other Informational PEPs" to "Informational PEPs" on all pages, since having an "Other" in the first heading seems wrong (as is the case with this topic index right now).

@CAM-Gerlach
Copy link
Member

My 2 cents: "Release Schedule" or "Release" are better names since they'll read better in the page heading ("Release Schedule PEPs"/"Release PEPs"). Right now, it looks to me like there's a grammatical error in there.

👍 to "Release"

@JelleZijlstra
Copy link
Member Author

The latest pushes add the PEPs I missed (thanks Adam for digging those up!), address other feedback, and rename the header to "Release".

Copy link
Member

@CAM-Gerlach CAM-Gerlach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I didn't mention it before, but like on #2670 , I suggest using a consistant header order with the existing packaging-topic PEPs, i.e. Topic after Type.

pep-0160.txt Outdated Show resolved Hide resolved
pep_sphinx_extensions/pep_zero_generator/constants.py Outdated Show resolved Hide resolved
Copy link
Member

@CAM-Gerlach CAM-Gerlach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @JelleZijlstra

@JelleZijlstra JelleZijlstra marked this pull request as ready for review October 7, 2022 01:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants