Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PEP 501: Fix footnotes #2715

Merged
merged 4 commits into from
Aug 4, 2022
Merged

PEP 501: Fix footnotes #2715

merged 4 commits into from
Aug 4, 2022

Conversation

hugovk
Copy link
Member

@hugovk hugovk commented Jul 15, 2022 •
edited
Loading

Fix these warnings:

pep-0501.txt:557: WARNING: Footnote [#] is not referenced.
pep-0501.txt:560: WARNING: Footnote [#] is not referenced.
pep-0501.txt:563: WARNING: Footnote [#] is not referenced.
pep-0501.txt:566: WARNING: Footnote [#] is not referenced.
pep-0501.txt:568: WARNING: Footnote [#] is not referenced.
pep-0501.txt:570: WARNING: Footnote [#] is not referenced.
pep-0501.txt:572: WARNING: Footnote [#] is not referenced.
pep-0501.txt:574: WARNING: Footnote [#] is not referenced.
pep-0501.txt:577: WARNING: Footnote [#] is not referenced.
pep-0501.txt:580: WARNING: Footnote [#] is not referenced.

These aren't referenced in the body text so let's convert them to bullet points (like in #2644 and others).

Plus update/fix some links and remove redundant emacs metadata.

Preview

https://pep-previews--2715.org.readthedocs.build/pep-0501/

@hugovk hugovk added the bug label Jul 15, 2022
@hugovk hugovk requested a review from ncoghlan as a code owner July 15, 2022 17:07
CAM-Gerlach
CAM-Gerlach reviewed Jul 29, 2022
View reviewed changes
Copy link
Member

@CAM-Gerlach CAM-Gerlach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Certainly an improvement, thanks, but why not just convert them to actual proper links while we're at it, no?

@hugovk
Copy link
Member Author

hugovk commented Jul 29, 2022

Converted!

CAM-Gerlach
CAM-Gerlach approved these changes Jul 29, 2022
View reviewed changes
Copy link
Member

@CAM-Gerlach CAM-Gerlach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @hugovk !

@hugovk hugovk merged commit f74f32b into python:main Aug 4, 2022
@hugovk hugovk deleted the pep501-fix-footnotes branch August 4, 2022 08:41
@hugovk hugovk mentioned this pull request Jan 14, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CAM-Gerlach CAM-Gerlach CAM-Gerlach approved these changes

@ncoghlan ncoghlan Awaiting requested review from ncoghlan

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hugovk @CAM-Gerlach