-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PEP 554: Fix citation references #2644
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please leave orphaned references. The linked information still captures relevant information. It's fine if they are turned into bullets, or something similar, in the References section.
Other than that, LGTM.
76e30ec
to
5709966
Compare
Updated! How does this look? https://pep-previews--2644.org.readthedocs.build/pep-0554/#references |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks for the improvements!
Thanks for the reviews! |
Fixed by converting to inline links.
This citation was added in #419.
The text uses:
`Communicating Sequential Processes`_ (CSP)
and:
So let's change this to a single citation:
Communicating Sequential Processes [CSP]_
and:
This citation was added in #424, but removed/orphaned in #1390.
Let's remove the orphan.
Similarly, added in #426 and removed/orphaned in #944.