Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PEP 0: Fix 'Page Source (GitHub)' #2401

Merged
merged 2 commits into from
Mar 9, 2022
Merged

PEP 0: Fix 'Page Source (GitHub)' #2401

merged 2 commits into from
Mar 9, 2022

Conversation

hugovk
Copy link
Member

@hugovk hugovk commented Mar 9, 2022

Fixes #2400.

For PEP-0, link to this repo instead of broken link https://github.com/python/peps/blob/main/pep-0000.rst

@hugovk hugovk requested a review from AA-Turner as a code owner March 9, 2022 22:18
@hugovk
Copy link
Member Author

hugovk commented Mar 9, 2022

@AA-Turner Feel free to modify this directly, or close and redo it!

@AA-Turner
Copy link
Member

I'd prefer to remove the link for PEP 0, as there is no source (we already special case in pep_footers.py) -- I'll push to this branch

A

@AA-Turner AA-Turner merged commit 08e37f7 into python:main Mar 9, 2022
@hugovk hugovk deleted the pep-0-fix-source-link branch March 10, 2022 05:39
@erlend-aasland erlend-aasland mentioned this pull request May 13, 2022
Closed
@erlend-aasland erlend-aasland mentioned this pull request Jun 27, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mariatta Mariatta Mariatta approved these changes

@AA-Turner AA-Turner Awaiting requested review from AA-Turner AA-Turner is a code owner

Assignees
No one assigned
Labels
CLA signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"Page Source (GitHub)" link is broken
4 participants
@hugovk @AA-Turner @Mariatta @the-knights-who-say-ni