Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Page Source (GitHub)" link is broken #2400

Closed
jefftriplett opened this issue Mar 9, 2022 · 2 comments · Fixed by #2401
Closed

"Page Source (GitHub)" link is broken #2400

jefftriplett opened this issue Mar 9, 2022 · 2 comments · Fixed by #2401
Assignees

Comments

@jefftriplett
Copy link
Member

jefftriplett commented Mar 9, 2022

(Congratulations. The new docs theme looks nice.)

I noticed that the "Page Source (GitHub)" link on https://peps.python.org/ is 404'ing because it's linked to https://github.com/python/peps/blob/main/pep-0000.rst

This page appears to be generated and is part of .gitignore so there is no page to point back to in version control. I am not sure if https://peps.python.org/pep-0000/ is the best link or just liking to GitHub directly.

See reference here:

<a id="source" href="https://github.com/python/peps/blob/main/{{sourcename}}">Page Source (GitHub)</a>

@brettcannon
Copy link
Member

This page appears to be generated and is part of .gitignore so there is no page to point back to in version control.

Yep, PEP 0 is entirely generated. Probably the only source link that would make sense is back to the repo itself.

@jefftriplett
Copy link
Member Author

🙏 thank you. Sorry, I didn't know enough to give you a PR with a fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants