Build with Travis, including users PRs.

[Carreau]

Prompted by #5 (Set up Travis to build the peps) and #16 (comment) :

(in this case we need to pull the branch locally and build the HTML version of the file)

I was wondering if I could setup Travis to auto build all my Pull requests, and push them on my gh-pages without committing my (encrypted) ssh key to this repo. And make that (relatively) simple for anyone to have the same functionality.

So this is my attempt at doing it.

Once something similar is into the main repo, then any user "just" have to

• set-up a secret DEPLOY_KEY env variable on Travis
• upload a corresponding public key as a Deploy Key on GitHub
• activate Travis.

That's it.

Now every branch they push get deploy on <username>.github.io/<fork-name>/<branch-name>/

( I suspect this could be partly automatized with the travis gem, but not an expert.)

I'm aware it will likely need some extra work once #15 is in.

That should allow – at least for regular contributor – to automatically have a rendered version of the modification they request to be pulled in.

Sidenote, it can't be done on each PR for obvious security reason. The only way would be to ask knight-who-says-ni to do it, but that would still be potentially dangerous.

And see my autodeployed version : https://carreau.github.io/peps/travis/pep-0000.html
and the travis build which deployed it.

[berkerpeksag]

Thank you for working on this. I think we should not complicate the build process just to build HTML version of a PEP file. I needed to pull your branch locally because it was a big chance and I wanted to double check it on my system.

I'm +1 for running ./genpepindex.py . on pull requests, but we need to make sure it will return a non-zero return code on error.

[Carreau]

Thank you for working on this. I think we should not complicate the build process just to build HTML version of a PEP file. I needed to pull your branch locally because it was a big chance and I wanted to double check it on my system.

I'm +1 for running ./genpepindex.py . on pull requests, but we need to make sure it will return a non-zero return code on error.

I understand, feel free to close if you think it's too complex/ not worth it. I still think it can be useful to read any newly proposed Pep, or any changes that would affect the global rendering.

[berkerpeksag]

If you can revert the changes in README.rst and delete .travis/travis.sh then we can use this PR to fix #5.

[Carreau]

If you can revert the changes in README.rst and delete .travis/travis.sh then we can use this PR to fix #5.

Done.

So you don't want auto-deploy by Travis ? Or do you keep that for later ?

[brettcannon]

Save auto-deploy for a separate PR. I have no issue with Travis zipping up the built PEPs as a build artifact that people can download to view post-CI if they want to see what the rendered version looks like.

[brettcannon]

I just wanted to double-check, @Carreau , are you good with this PR being merged? Only asking because you still have Work in progress in the title.

[brettcannon]

I should also mention I turned on Travis support for this repo in preparation of this PR landing: https://travis-ci.org/python/peps

[Carreau]

Yes, sorry. I'll fix the title when I'm back on a computer.
On Jun 20, 2016 09:42, "Brett Cannon" [email protected] wrote:

I should also mention I turned on Travis support for this repo in
preparation of this PR landing: https://travis-ci.org/python/peps

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#17 (comment), or mute
the thread
https://github.com/notifications/unsubscribe/AAUez_zV3S3W0n2dEZfcCRLuSechfU7zks5qNsLsgaJpZM4I5G-x
.

[brettcannon]

Fixed it for you; just needed to make sure it no longer applied. 😄

[brettcannon]

Thanks for the patch!

[Carreau]

Thanks, will submit another later on that uses travis to build and deploy.

On Mon, Jun 20, 2016 at 10:20 AM, Brett Cannon [email protected]
wrote:

Thanks for the patch!

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#17 (comment), or mute
the thread
https://github.com/notifications/unsubscribe/AAUez2ptS98E-pRVK9FXSNPTFeMvEuv1ks5qNsvPgaJpZM4I5G-x
.