-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Move all PEPs into subdirectory #15
Conversation
This change moves all PEPs into the `peps/` subdirectory. The HTML files generated by `pep2html.py` will be located in `output/`. The `make` command to convert a single PEP to HTML has changed slightly **if** you specify the path. It's still same the when specifying the id. From: `make pep-0020.txt` To: `make peps/pep-0020.txt` ... just use tab completion ;)
79da508
to
62fa8e9
Compare
Nice clean-up, thanks! This is going to break python.org's PEP converter (should be easy to fix it but I'm not sure about the testing part). |
Okay, sorry about that. What/where can I find this python.org PEP converter? And where's the testing part? Sent from my iPhone
|
The PEP converter lives in https://github.com/python/pythondotorg/tree/master/peps. The fake PEP repository we use for testing is in https://github.com/python/pythondotorg/tree/master/peps/tests/fake_pep_repo |
Okay, I'm going to work on that as good as I can and keep you posted. |
As far as I understood from @brettcannon comment here, peps should moved to their own subdomain anyway. |
They should eventually, but there's no timeline on that so there's no need to design for it now. |
Yes, this change would not be necessary if you switch to sphinx now... |
I've already talked to @berkerpeksag about what he's written here earlier. I've had a look at pythondotorg's PEP converter and it seems to me that if the Maybe that's a no-brainer for someone here? |
Just closing/reopening this so Travis will pick it up. |
Maybe we should close this PR since it's going to perpetually be in conflict while PEPs are being worked on? |
Seems reasonable to me. |
Then I'm closing it. Thanks for the attempt, @timofurrer . |
This change moves all PEPs into the
peps/
subdirectory. The HTML files generated bypep2html.py
will be located inoutput/
.The
make
command to convert a single PEP to HTML has changed slightly if you specify the path.It's still the same when specifying the id.
From:
make pep-0020.txt
To:
make peps/pep-0020.txt
... just use tab completion ;)
Question: When you now open a converted HTML PEP locally in your browser you won't have any styles because the css files are still located in the project root directory and not in
output
. Do you think it makes sense to copy/link the css files to the output directory as well?Please let me know if I've missed something to change or if this does not fit your needs yet.
Refs: #10