Fix callable instance variable support #10548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
|
This is great! It's a very long-lasting bug so it's wonderful to get it fixed. The mypy-primer output looks very promising. https://github.com/willmcgugan/rich/blob/master/rich/pager.py#L20 seems like it's missing a |
|
Yes, mypy-primer looks very promising! (I'm also excited, thinking about all the |
This comment has been minimized.
This comment has been minimized.
|
Diff from mypy_primer, showing the effect of this PR on open source code: pydantic (https://github.com/samuelcolvin/pydantic.git)
+ pydantic/validators.py:503: error: unused "type: ignore" comment
+ pydantic/main.py:556: error: Redundant cast to "Callable[[Any], Any]" [redundant-cast]
+ pydantic/dataclasses.py:172: error: unused "type: ignore" comment
+ pydantic/dataclasses.py:173: error: unused "type: ignore" comment
sphinx (https://github.com/sphinx-doc/sphinx.git)
+ sphinx/domains/std.py: note: In member "handle_signature" of class "GenericObject":
+ sphinx/domains/std.py:58:20: error: Too few arguments
+ sphinx/domains/std.py:58:36: error: Argument 1 has incompatible type "BuildEnvironment"; expected "GenericObject"
+ sphinx/domains/std.py:58:46: error: Argument 2 has incompatible type "str"; expected "BuildEnvironment"
+ sphinx/domains/std.py:58:51: error: Argument 3 has incompatible type "desc_signature"; expected "str"
rich (https://github.com/willmcgugan/rich.git)
+ rich/pager.py:26: error: Too few arguments
graphql-core (https://github.com/graphql-python/graphql-core.git)
+ src/graphql/execution/execute.py:207: error: unused "type: ignore" comment
+ src/graphql/execution/execute.py:208: error: unused "type: ignore" comment
+ src/graphql/execution/execute.py:879: error: unused "type: ignore" comment
|
msullivan
approved these changes
Jun 13, 2021
johtso
added a commit
to johtso/httpx-caching
that referenced
this pull request
Jun 20, 2021
Currently bumping into a bug with py3.6 python/mypy#10548
This was referenced Sep 20, 2021
|
Just wanted to say thank you again! This fixes a longstanding issue! |
JukkaL
added a commit
that referenced
this pull request
Nov 17, 2021
This reverts commit 6ab0efc. Reverting the change since it causes a significant backward compatibility break. Code like this previously worked as expected: ``` class C: def f(self) -> None: pass g = f C().g() ``` However, #10548 broke this in a subtle way (no error on definition), and instead required the introduction of a ClassVar annotation for `g`, which is non-intuitive and error-prone. For example, some typeshed stubs use method aliases such as the above (e.g. stubs for `logging`), and the change broke those stubs. It's also arguably inconsistent, since normally ClassVar annotations are optional. Any fix to the original issue should avoid breaking method aliases such as the above. Hopefully the fix can be adjusted suitably. The PR may have broken incremental mode somehow as well -- cached and uncached runs sometimes produce different results. The root cause is still unclear, however.
JukkaL
added a commit
that referenced
this pull request
Nov 17, 2021
This reverts commit 6ab0efc. Reverting the change since it causes a significant backward compatibility break. Code like this previously worked as expected: ``` class C: def f(self, ...) -> None: pass g = f C().g(...) # Now sometimes generates an error ``` However, #10548 broke this in a subtle way (no error on definition, it sometimes generates an error on call), and instead required the introduction of a ClassVar annotation for `g`, which is non-intuitive and error-prone. For example, some typeshed stubs use method aliases such as the above (e.g. stubs for `logging`), and the change broke those stubs. It's also arguably inconsistent, since normally ClassVar annotations are optional. Any fix to the original issue should avoid breaking method aliases such as the above. Hopefully the fix can be adjusted suitably. The PR may have broken incremental mode somehow as well -- cached and uncached runs sometimes produce different results. The root cause is still unclear, however.
JukkaL
added a commit
that referenced
this pull request
Nov 17, 2021
This reverts commit 6ab0efc. Reverting the change since it causes a significant backward compatibility break. Code like this previously worked as expected: ``` class C: def f(self, ...) -> None: pass g = f C().g(...) # Now sometimes generates an error ``` However, #10548 broke this in a subtle way (no error on definition, it sometimes generates an error on call), and instead required the introduction of a ClassVar annotation for `g`, which is non-intuitive and error-prone. For example, some typeshed stubs use method aliases such as the above (e.g. stubs for `logging`), and the change broke those stubs. It's also arguably inconsistent, since normally ClassVar annotations are optional. Any fix to the original issue should avoid breaking method aliases such as the above. Hopefully the fix can be adjusted suitably. The PR may have broken incremental mode somehow as well -- cached and uncached runs sometimes produce different results. The root cause is still unclear, however.
tushar-deepsource
pushed a commit
to DeepSourceCorp/mypy
that referenced
this pull request
Jan 20, 2022
…n#11571) This reverts commit 6ab0efc. Reverting the change since it causes a significant backward compatibility break. Code like this previously worked as expected: ``` class C: def f(self, ...) -> None: pass g = f C().g(...) # Now sometimes generates an error ``` However, python#10548 broke this in a subtle way (no error on definition, it sometimes generates an error on call), and instead required the introduction of a ClassVar annotation for `g`, which is non-intuitive and error-prone. For example, some typeshed stubs use method aliases such as the above (e.g. stubs for `logging`), and the change broke those stubs. It's also arguably inconsistent, since normally ClassVar annotations are optional. Any fix to the original issue should avoid breaking method aliases such as the above. Hopefully the fix can be adjusted suitably. The PR may have broken incremental mode somehow as well -- cached and uncached runs sometimes produce different results. The root cause is still unclear, however.
ilevkivskyi
pushed a commit
to ilevkivskyi/mypy
that referenced
this pull request
Aug 12, 2022
Fixes python#708 and Fixes python#5485 Prevent handling as bounded method of callable members declared as instance variables.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #708 and Fixes #5485
Prevent handling as bounded method of callable members declared as instance variables.