Fix support of dataclass callable fields #10536
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is related to #708 and #5485, but fix them for dataclasses only. (Is there really an issue for regular classes?)
mypy currently handle dataclass callable fields as instance methods, as they are annotated at class level the same way a method would be. As a consequence, field node attribute
is_initialized_in_class
isTrue
.Here is an illustration of the current mypy behavior, comparing "regular" instance field annotation and dataclass one:
By setting field node
is_initialized_in_class
toFalse
, the field is then treated the same way it would be when declared with annotated assignment in__init__
method.A first PR #10292 by @aecay concerning this issue was merged one month ago, but its implementation was more complex and did not fix the bug for frozen dataclasses, so I've reverted it. I hope there is no problem with that.
Test Plan
Add unit tests: