Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.11] gh-96478: Fix new test when run in refleak mode (GH-96615) #97601

Merged
merged 1 commit into from
Sep 27, 2022

Conversation

miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Sep 27, 2022

./python.exe -m test -R : test.test_typing would fail, apparently
because the dictionary used in the @patch decorator was modified.
(cherry picked from commit f0d9136)

Co-authored-by: Jelle Zijlstra [email protected]

./python.exe -m test -R : test.test_typing would fail, apparently
because the dictionary used in the @patch decorator was modified.
(cherry picked from commit f0d9136)

Co-authored-by: Jelle Zijlstra <[email protected]>
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good bot.

@vstinner
Copy link
Member

Currently, ./python -m test -R 3:3 test_typing fails on test_overload_on_compiled_functions(). With this backport, it works as expected.

@pablogsal: It would be good to get this fix into Python 3.11.0 final.

@vstinner
Copy link
Member

Currently, many Refleaks 3.11 buildbots are failing because of this missing fix:

Capture d’écran du 2022-09-27 16-33-31

@miss-islington
Copy link
Contributor Author

Status check is done, and it's a success ✅.

@miss-islington miss-islington merged commit f391b3c into python:3.11 Sep 27, 2022
@miss-islington miss-islington deleted the backport-f0d9136-3.11 branch September 27, 2022 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants