-
-
Notifications
You must be signed in to change notification settings - Fork 30.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-96478: Test @overload
on C functions
#96479
Conversation
0355a7f
to
189797f
Compare
Co-authored-by: Alex Waygood <[email protected]>
Thanks @sobolevn for the PR, and @JelleZijlstra for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11. |
Sorry @sobolevn and @JelleZijlstra, I had trouble checking out the |
Thanks @sobolevn for the PR, and @JelleZijlstra for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11. |
GH-96604 is a backport of this pull request to the 3.11 branch. |
Co-authored-by: Alex Waygood <[email protected]> (cherry picked from commit f177f6f) Co-authored-by: Nikita Sobolev <[email protected]>
I think this may be the cause of some buildbot failures. In particular, on the second repetition of the test suite (e.g., when running -R3:3), I get this:
cc @pablogsal |
Fixed in #96615 |
Ah my bad, thanks! |
Co-authored-by: Alex Waygood <[email protected]> (cherry picked from commit f177f6f) Co-authored-by: Nikita Sobolev <[email protected]>
Right, all Refleaks 3.11 buildbots are failing since commit 2a5e333: the 3.11 branch also needs PR #96615 fix. => I created PR #97601 backport to fix test_typing in the 3.11 branch. |
Now, we have this covered, including a side-effect.
@overload
decorator on compiled functions is not tested #96478