Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-46005: add note about setuptools to Doc/extending/building.rst #30062

Closed
wants to merge 2 commits into from

Conversation

sobolevn
Copy link
Member

@sobolevn sobolevn commented Dec 11, 2021

@bedevere-bot bedevere-bot added the docs Documentation in the Doc dir label Dec 11, 2021
@AlexWaygood AlexWaygood added the needs backport to 3.10 only security fixes label Dec 13, 2021
Copy link
Member

@merwok merwok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I would remove the news snippet. It will not really provide value when collected in a NEWS document (unless I’ve missed recent conventions, NEWS does not duplicate the full git changelog).

@merwok merwok added the needs backport to 3.9 only security fixes label Jan 2, 2022
@merwok
Copy link
Member

merwok commented Jan 2, 2022

Wasn’t there a python.github.io site configured to show docs built from pull requests?

@AlexWaygood
Copy link
Member

Wasn’t there a python.github.io site configured to show docs built from pull requests?

The artifact is uploaded here 🙂

@AlexWaygood
Copy link
Member

AlexWaygood commented Jan 2, 2022

BTW, @merwok, should this be backported to 3.9? I think distutils was only deprecated in 3.10.

@merwok merwok added needs backport to 3.9 only security fixes and removed needs backport to 3.9 only security fixes labels Jan 2, 2022
@merwok
Copy link
Member

merwok commented Jan 2, 2022

Yes, that’s the artifact, it needs to be downloaded and extracted. I was referring to a website that’s easier to look at 🙂

I checked the 3.9 branch and the _setuptools_disclaimer.rst is there, so we can backport.
The formal deprecation may be in 3.10, but the package was minimally maintained before and setuptools was recommended.

@AlexWaygood
Copy link
Member

Yes, that’s the artifact, it needs to be downloaded and extracted. I was referring to a website that’s easier to look at 🙂

I don't know of such a website (but then, I'm fairly new to CPython! If there is one, I'd be very interested to know about it...)

Having downloaded and extracted it myself, this is what it looks like, anyhow!
image

@sobolevn
Copy link
Member Author

sobolevn commented Jan 2, 2022

@AlexWaygood probably @merwok is asking about #30272 and #19025

Right now the automation does not work 😞

@merwok merwok changed the title bpo-46005: add setuptools note to Doc/extending/building.rst bpo-46005: add note about setuptools to Doc/extending/building.rst Jan 2, 2022
@taleinat
Copy link
Contributor

Thanks for the PR, @sobolevn!

I'm not sold on this change though. I'm marking this PR as "do not merge" for now, until the discussion on the b.p.o. issue reaches a conclusion.

@serhiy-storchaka serhiy-storchaka added needs backport to 3.11 only security fixes and removed needs backport to 3.9 only security fixes labels May 20, 2022
@AA-Turner
Copy link
Member

Trigger CLA

@AA-Turner AA-Turner closed this Jun 9, 2022
@AA-Turner AA-Turner reopened this Jun 9, 2022
@sobolevn
Copy link
Member Author

sobolevn commented Nov 5, 2022

I am closing this PR, because distutils module was completely removed.
There will be major changes to its documentation.

@sobolevn sobolevn closed this Nov 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting merge DO-NOT-MERGE docs Documentation in the Doc dir needs backport to 3.10 only security fixes needs backport to 3.11 only security fixes skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants