-
-
Notifications
You must be signed in to change notification settings - Fork 31.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bpo-46005: add note about setuptools to Doc/extending/building.rst #30062
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but I would remove the news snippet. It will not really provide value when collected in a NEWS document (unless I’ve missed recent conventions, NEWS does not duplicate the full git changelog).
Wasn’t there a python.github.io site configured to show docs built from pull requests? |
The artifact is uploaded here 🙂 |
BTW, @merwok, should this be backported to 3.9? I think |
Yes, that’s the artifact, it needs to be downloaded and extracted. I was referring to a website that’s easier to look at 🙂 I checked the 3.9 branch and the _setuptools_disclaimer.rst is there, so we can backport. |
@AlexWaygood probably @merwok is asking about #30272 and #19025 Right now the automation does not work 😞 |
setuptools
note to Doc/extending/building.rst
Thanks for the PR, @sobolevn! I'm not sold on this change though. I'm marking this PR as "do not merge" for now, until the discussion on the b.p.o. issue reaches a conclusion. |
Trigger CLA |
I am closing this PR, because |
https://bugs.python.org/issue46005