Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-37860: Enable docs deploy previews through GitHub Actions #19025

Closed
wants to merge 21 commits into from

Conversation

epicfaace
Copy link
Contributor

@epicfaace epicfaace commented Mar 15, 2020

@hugovk
Copy link
Member

hugovk commented Jan 12, 2022

This looks good, although one downside is it creates a new directory for each and every commit pushed to a PR:

That's going to get pretty big and fast, so would need to have some way to cleanup old ones.

It would be better to use the PR number instead of commit SHA and only build PRs that change docs or docs build logic.

Also I wonder if that amount of churn on a single branch would have a performance impact on the rest of the Git repo?

Perhaps another host server would be better.

@epicfaace
Copy link
Contributor Author

  • 586 MB for 10 builds

Yeah, and GitHub Pages also has a hard limit of 1 GB in size -- https://docs.github.com/en/pages/getting-started-with-github-pages/about-github-pages#usage-limits. Why is the docs site so large again? Are there certain large static files that can be symlinked / shared between deploy previews?

It would be better to use the PR number instead of commit SHA and only build PRs that change docs or docs build logic.

Good idea.

Also I wonder if that amount of churn on a single branch would have a performance impact on the rest of the Git repo?

I don't think it will be an issue as long as we clean up merged PRs -- so we only include PRs in this branch that are currently open.

@epicfaace epicfaace mannequin mentioned this pull request Apr 16, 2022
@epicfaace
Copy link
Contributor Author

Closing in favor of #92852

@epicfaace epicfaace closed this May 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants