-
-
Notifications
You must be signed in to change notification settings - Fork 31.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bpo-37860: Enable docs deploy previews through GitHub Actions #19025
Conversation
Create deploy-previews.yml
This looks good, although one downside is it creates a new directory for each and every commit pushed to a PR:
That's going to get pretty big and fast, so would need to have some way to cleanup old ones. It would be better to use the PR number instead of commit SHA and only build PRs that change docs or docs build logic. Also I wonder if that amount of churn on a single branch would have a performance impact on the rest of the Git repo? Perhaps another host server would be better. |
Yeah, and GitHub Pages also has a hard limit of 1 GB in size -- https://docs.github.com/en/pages/getting-started-with-github-pages/about-github-pages#usage-limits. Why is the docs site so large again? Are there certain large static files that can be symlinked / shared between deploy previews?
Good idea.
I don't think it will be an issue as long as we clean up merged PRs -- so we only include PRs in this branch that are currently open. |
Closing in favor of #92852 |
Sample PR: epicfaace#7
https://bugs.python.org/issue37860