gh-126525: Fix makeunicodedata.py output on macOS and Windows
#126526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sobolevn
added
skip news
needs backport to 3.12
sobolevn
changed the title
makeunicodedata.py output on macosmakeunicodedata.py output on macos and windows
|
@erlend-aasland this is related to the work I do with the better CI checks of autogenerated files. Since you reviewed the last PR, maybe you are also interested in this one? This will unblock #126682 |
erlend-aasland
approved these changes
Nov 12, 2024
erlend-aasland
changed the title
makeunicodedata.py output on macos and windowsmakeunicodedata.py output on macOS and Windows
|
Thanks @sobolevn for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13. |
|
Thank you! 🤝 |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Nov 12, 2024
…pythonGH-126526) (cherry picked from commit f223efb) Co-authored-by: sobolevn <[email protected]>
|
GH-126725 is a backport of this pull request to the 3.13 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Nov 12, 2024
…pythonGH-126526) (cherry picked from commit f223efb) Co-authored-by: sobolevn <[email protected]>
|
GH-126726 is a backport of this pull request to the 3.12 branch. |
picnixz
pushed a commit
to picnixz/cpython
that referenced
this pull request
Dec 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After - it generates the expected file. To test run
make regen-unicodedatamake regen-unicodedataproduces different file on macos and windows #126525