Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make regen-unicodedata produces different file on macos and windows #126525

Closed
sobolevn opened this issue Nov 7, 2024 · 0 comments
Closed

make regen-unicodedata produces different file on macos and windows #126525

sobolevn opened this issue Nov 7, 2024 · 0 comments
Assignees
@sobolevn
Labels
build The build process and cross-build OS-mac OS-windows topic-unicode type-bug An unexpected behavior, bug, or error

Comments

@sobolevn
Copy link
Member

sobolevn commented Nov 7, 2024 •
edited by bedevere-app bot
Loading

Bug report

  1. cpython/Tools/unicode/makeunicodedata.py

    Line 38 in 2a6b6b3

    SCRIPT = sys.argv[0]

  2. cpython/Tools/unicode/makeunicodedata.py

    Line 292 in 2a6b6b3

    fprint("/* this file was generated by %s %s */" % (SCRIPT, VERSION))

This produces:

/* this file was generated by ./Tools/unicode/makeunicodedata.py 3.3 */

on macos.

Compare it with the current file:

cpython/Modules/unicodedata_db.h

Line 1 in 2a6b6b3

/* this file was generated by Tools/unicode/makeunicodedata.py 3.3 */

I will send a fix to produce the same results on different platforms.

Linked PRs
@sobolevn sobolevn added type-bug An unexpected behavior, bug, or error OS-mac build The build process and cross-build topic-unicode labels Nov 7, 2024
@sobolevn sobolevn self-assigned this Nov 7, 2024
sobolevn added a commit to sobolevn/cpython that referenced this issue Nov 7, 2024
@sobolevn
pythongh-126525: Fix makeunicodedata.py output on macos
122ec16
@bedevere-app bedevere-app bot mentioned this issue Nov 7, 2024
Merged
@sobolevn sobolevn changed the title make regen-unicodedata produces different file on macos make regen-unicodedata produces different file on macos and windows Nov 12, 2024
sobolevn added a commit that referenced this issue Nov 12, 2024
@sobolevn
gh-126525: Fix makeunicodedata.py output on macOS and Windows (#126526
f223efb 
)
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Nov 12, 2024
@sobolevn @miss-islington
pythongh-126525: Fix makeunicodedata.py output on macOS and Windows (…
34133dd 
…pythonGH-126526)

(cherry picked from commit f223efb)

Co-authored-by: sobolevn <[email protected]>
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Nov 12, 2024
@sobolevn @miss-islington
pythongh-126525: Fix makeunicodedata.py output on macOS and Windows (…
0335e3a 
…pythonGH-126526)

(cherry picked from commit f223efb)

Co-authored-by: sobolevn <[email protected]>
This was referenced Nov 12, 2024
Merged
Merged
sobolevn added a commit that referenced this issue Nov 12, 2024
@miss-islington @sobolevn
[3.12] gh-126525: Fix makeunicodedata.py output on macOS and Windows (
bc31c73 
GH-126526) (#126726)

gh-126525: Fix `makeunicodedata.py` output on macOS and Windows (GH-126526)
(cherry picked from commit f223efb)

Co-authored-by: sobolevn <[email protected]>
sobolevn added a commit that referenced this issue Nov 12, 2024
@miss-islington @sobolevn
[3.13] gh-126525: Fix makeunicodedata.py output on macOS and Windows (
6cefffc 
GH-126526) (#126725)

gh-126525: Fix `makeunicodedata.py` output on macOS and Windows (GH-126526)
(cherry picked from commit f223efb)

Co-authored-by: sobolevn <[email protected]>
@github-actions github-actions bot mentioned this issue Dec 1, 2024
Closed
picnixz pushed a commit to picnixz/cpython that referenced this issue Dec 8, 2024
@sobolevn @picnixz
pythongh-126525: Fix makeunicodedata.py output on macOS and Windows (…
3b4a3a2 
…python#126526)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sobolevn sobolevn

Labels
build The build process and cross-build OS-mac OS-windows topic-unicode type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sobolevn