-
-
Notifications
You must be signed in to change notification settings - Fork 30.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-126433: Fix compiler warning on 32-bit Windows #126448
Conversation
vstinner
commented
Nov 5, 2024
•
edited by bedevere-app
bot
Loading
edited by bedevere-app
bot
- Issue: Compile warnings in "i686-pc-windows-msvc/msvc (Debug)" #126433
Fix the following warning:
@msprotz: Should I fix the issue in HACL upstream first? Or do you want to fix it upstream? |
SecureZeroMemory() second parameter type is SIZE_T: https://learn.microsoft.com/en-us/previous-versions/windows/desktop/legacy/aa366877(v=vs.85) |
If you could fix upstream that would be optimal. The file is in |
@msprotz: I created hacl-star/hacl-star#1004. |
It has been merged. Can I run |
You need to:
And then you should be good! Cheers. |
I updated
On my upstream PR, the bot said "dist is not automatically re-generated, be sure to do it manually." Oops, I didn't do that! Should I modify manually the 5 files? |
The propagation happens via a CI job run weekly on weekends I believe, but I triggered it manually for you to speed things up. Should be good soon. Thanks! |
Oh ok, I will wait next week for the CI to update these files. |
Run Modules/_hacl/refresh.sh and update SBOM. Retrieve the change: "Lib_Memzero0.c: Fix compiler warning on 32-bit Windows".
I created PR gh-126791 to update hacl-star and retrieve the change fixing the warning. I close this PR. |