Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compile warnings in "i686-pc-windows-msvc/msvc (Debug)" #126433

Closed
sobolevn opened this issue Nov 5, 2024 · 6 comments
Closed

Compile warnings in "i686-pc-windows-msvc/msvc (Debug)" #126433

sobolevn opened this issue Nov 5, 2024 · 6 comments
Labels
extension-modules C modules in the Modules dir OS-windows type-bug An unexpected behavior, bug, or error

Comments

@sobolevn
Copy link
Member

sobolevn commented Nov 5, 2024

Bug report

Link: https://github.com/sobolevn/cpython/actions/runs/11679282454/job/32520346523#step:4:793

D:\a\cpython\cpython\Modules\blake2module.c(477,23): warning C4018: '>': signed/unsigned mismatch [D:\a\cpython\cpython\PCbuild\pythoncore.vcxproj]
D:\a\cpython\cpython\Modules\blake2module.c(488,25): warning C4018: '>': signed/unsigned mismatch [D:\a\cpython\cpython\PCbuild\pythoncore.vcxproj]
D:\a\cpython\cpython\Modules\blake2module.c(537,22): warning C4018: '>': signed/unsigned mismatch [D:\a\cpython\cpython\PCbuild\pythoncore.vcxproj]
D:\a\cpython\cpython\Modules\_hacl\Lib_Memzero0.c(39,27): warning C4244: 'function': conversion from 'uint64_t' to 'SIZE_T', possible loss of data [D:\a\cpython\cpython\PCbuild\pythoncore.vcxproj]
D:\a\cpython\cpython\Modules\_interpchannelsmodule.c(2096,30): warning C4244: '=': conversion from 'int64_t' to 'Py_ssize_t', possible loss of data [D:\a\cpython\cpython\PCbuild\pythoncore.vcxproj]
D:\a\cpython\cpython\Modules\_interpchannelsmodule.c(2064,27): warning C4244: 'initializing': conversion from 'int64_t' to 'Py_ssize_t', possible loss of data [D:\a\cpython\cpython\PCbuild\pythoncore.vcxproj]
D:\a\cpython\cpython\Modules\_winapi.c(2381,23): warning C4018: '<': signed/unsigned mismatch [D:\a\cpython\cpython\PCbuild\pythoncore.vcxproj]
D:\a\cpython\cpython\Modules\_winapi.c(2529,49): warning C4018: '<': signed/unsigned mismatch [D:\a\cpython\cpython\PCbuild\pythoncore.vcxproj]
D:\a\cpython\cpython\PC\venvlauncher.c(226,50): warning C4018: '<': signed/unsigned mismatch [D:\a\cpython\cpython\PCbuild\venvwlauncher.vcxproj]
D:\a\cpython\cpython\PC\venvlauncher.c(226,50): warning C4018: '<': signed/unsigned mismatch [D:\a\cpython\cpython\PCbuild\venvlauncher.vcxproj]
D:\a\cpython\cpython\Modules\_ssl.c(4926,27): warning C4018: '>': signed/unsigned mismatch [D:\a\cpython\cpython\PCbuild\_ssl.vcxproj]
D:\a\cpython\cpython\Modules\_ssl.c(4926,58): warning C4018: '>': signed/unsigned mismatch [D:\a\cpython\cpython\PCbuild\_ssl.vcxproj]
D:\a\cpython\cpython\Modules\_ssl.c(5039,18): warning C4018: '>': signed/unsigned mismatch [D:\a\cpython\cpython\PCbuild\_ssl.vcxproj]

Linked PRs

@sobolevn sobolevn added type-bug An unexpected behavior, bug, or error extension-modules C modules in the Modules dir labels Nov 5, 2024
@sobolevn sobolevn changed the title Compile warnings when in "i686-pc-windows-msvc/msvc (Debug)" Compile warnings in "i686-pc-windows-msvc/msvc (Debug)" Nov 5, 2024
@vstinner
Copy link
Member

vstinner commented Nov 5, 2024

Do you plan to write a PR to fix them? If not, I'm interested to fix these warnings.

@sobolevn
Copy link
Member Author

sobolevn commented Nov 5, 2024

Please, go ahead! I don't have windows to verify that they are fixed!

vstinner added a commit to vstinner/cpython that referenced this issue Nov 5, 2024
vstinner added a commit to vstinner/cpython that referenced this issue Nov 5, 2024
vstinner added a commit to vstinner/cpython that referenced this issue Nov 5, 2024
Fix compiler warnings on 32-bit Windows: change channel_info.count
type from Py_ssize_t to int64_t in _interpchannelsmodule.c.
vstinner added a commit to vstinner/cpython that referenced this issue Nov 5, 2024
kumaraditya303 pushed a commit that referenced this issue Nov 6, 2024
Fix compiler warnings on 32-bit Windows: change channel_info.count
type from Py_ssize_t to int64_t in _interpchannelsmodule.c.
@kumaraditya303 kumaraditya303 reopened this Nov 6, 2024
@kumaraditya303
Copy link
Contributor

Reopened for the HACL remaining issue.

vstinner added a commit to vstinner/cpython that referenced this issue Nov 13, 2024
Run Modules/_hacl/refresh.sh and update SBOM.

Retrieve the change: "Lib_Memzero0.c: Fix compiler warning on 32-bit
Windows".
@gpshead
Copy link
Member

gpshead commented Nov 13, 2024

does this need backporting?

miss-islington pushed a commit to miss-islington/cpython that referenced this issue Nov 14, 2024
Fix compiler warnings on 32-bit Windows: change channel_info.count
type from Py_ssize_t to int64_t in _interpchannelsmodule.c.
(cherry picked from commit 09d7083)

Co-authored-by: Victor Stinner <[email protected]>
vstinner added a commit to vstinner/cpython that referenced this issue Nov 14, 2024
@vstinner
Copy link
Member

does this need backporting?

I created backports.

vstinner added a commit that referenced this issue Nov 14, 2024
…126826)

gh-126433: Change channel_info.count to int64_t (GH-126447)

Fix compiler warnings on 32-bit Windows: change channel_info.count
type from Py_ssize_t to int64_t in _interpchannelsmodule.c.
(cherry picked from commit 09d7083)

Co-authored-by: Victor Stinner <[email protected]>
vstinner added a commit that referenced this issue Nov 14, 2024
…126827)

gh-126433: Fix compiler warnings on 32-bit Windows (#126444)

(cherry picked from commit 0b67ce9)
gpshead pushed a commit that referenced this issue Nov 15, 2024
Retrieve the change: "Lib_Memzero0.c: Fix compiler warning on 32-bit Windows".
@vstinner
Copy link
Member

There is no compiler warnings anymore on 32-bit Windows on Python 3.12, 3.13 and main branches. I close the issue.

picnixz pushed a commit to picnixz/cpython that referenced this issue Dec 8, 2024
Fix compiler warnings on 32-bit Windows: change channel_info.count
type from Py_ssize_t to int64_t in _interpchannelsmodule.c.
picnixz pushed a commit to picnixz/cpython that referenced this issue Dec 8, 2024
Retrieve the change: "Lib_Memzero0.c: Fix compiler warning on 32-bit Windows".
ebonnal pushed a commit to ebonnal/cpython that referenced this issue Jan 12, 2025
Fix compiler warnings on 32-bit Windows: change channel_info.count
type from Py_ssize_t to int64_t in _interpchannelsmodule.c.
ebonnal pushed a commit to ebonnal/cpython that referenced this issue Jan 12, 2025
Retrieve the change: "Lib_Memzero0.c: Fix compiler warning on 32-bit Windows".
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
extension-modules C modules in the Modules dir OS-windows type-bug An unexpected behavior, bug, or error
Projects
None yet
Development

No branches or pull requests

4 participants