Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add JOBS parameter to docs Makefile #101395

Merged
merged 2 commits into from
Jan 31, 2023
Merged

Conversation

christopheNan
Copy link
Contributor

separate parameter JOBS in order to be able to specify it in command line (used by translators who build documentation in their language)

related to https://git.afpy.org/AFPy/python-docs-fr/pulls/23

separate parameter JOBS in order to be able to specify it in command line
(used by translators who build documentation in their language)

related to https://git.afpy.org/AFPy/python-docs-fr/pulls/23
@christopheNan
Copy link
Contributor Author

Would be nice to backport to 3.11

@hugovk
Copy link
Member

hugovk commented Jan 29, 2023

Sounds reasonable. Do translators want to set it to some higher or lower value? Does auto not work for them?

Please could you move JOBS in between BLURB and PAPER?

@hugovk hugovk added needs backport to 3.10 only security fixes needs backport to 3.11 only security fixes labels Jan 29, 2023
@hauntsaninja hauntsaninja changed the title Documentation Makefile adjustement Documentation Makefile adjustment Jan 29, 2023
@christopheNan
Copy link
Contributor Author

Sounds reasonable. Do translators want to set it to some higher or lower value? Does auto not work for them?

'auto' is good as a default value. As far as I am concerned, it happens that I lower the value (to 1). I ask for this modification as it is transparent for default usage of the Makefile.

Copy link
Member

@hugovk hugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@hugovk hugovk changed the title Documentation Makefile adjustment Add JOBS parameter to docs Makefile Jan 31, 2023
@hugovk hugovk merged commit 1a62ae8 into python:main Jan 31, 2023
@miss-islington
Copy link
Contributor

Thanks @christopheNan for the PR, and @hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-101459 is a backport of this pull request to the 3.11 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Jan 31, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 31, 2023
(cherry picked from commit 1a62ae8)

Co-authored-by: Christophe Nanteuil <[email protected]>
@bedevere-bot
Copy link

GH-101460 is a backport of this pull request to the 3.10 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Jan 31, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 31, 2023
(cherry picked from commit 1a62ae8)

Co-authored-by: Christophe Nanteuil <[email protected]>
miss-islington added a commit that referenced this pull request Jan 31, 2023
(cherry picked from commit 1a62ae8)

Co-authored-by: Christophe Nanteuil <[email protected]>
miss-islington added a commit that referenced this pull request Jan 31, 2023
(cherry picked from commit 1a62ae8)

Co-authored-by: Christophe Nanteuil <[email protected]>
mdboom pushed a commit to mdboom/cpython that referenced this pull request Jan 31, 2023
carljm added a commit to carljm/cpython that referenced this pull request Jan 31, 2023
* main:
  pythongh-101440: fix json snippet error in logging-cookbook.rst (python#101439)
  pythongh-99276 - Updated Doc/faq/general.rst (python#101396)
  Add JOBS parameter to docs Makefile (python#101395)
  pythongh-98831: rewrite GET_LEN, GET_ITER, BEFORE_WITH and a few simple opcodes in the instruction definition DSL (python#101443)
  pythongh-77607: Improve accuracy of os.path.join docs (python#101406)
  Fixes typo in asyncio.TaskGroup context manager code example (python#101449)
  pythongh-98831: Clean up and add cache size static_assert to macro (python#101442)
  pythongh-99955: use SUCCESS/ERROR return values in optimizer and assembler. Use RETURN_IF_ERROR where appropriate. Fix a couple of bugs. (python#101412)
egeakman added a commit to python/python-docs-tr that referenced this pull request Feb 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants