Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reconsider get_header / set_header #256

Closed
aaugustin opened this issue Aug 27, 2017 · 2 comments
Closed

Reconsider get_header / set_header #256

aaugustin opened this issue Aug 27, 2017 · 2 comments
Labels
enhancement

Comments

@aaugustin
Copy link
Member

get_header was an interesting experiment but it makes it hard to work with multi-value headers.

set_header is symmetrical, for consistency it must be reconsidered as well.
@aaugustin aaugustin self-assigned this Aug 27, 2017
@aaugustin aaugustin added this to the someday milestone Sep 3, 2017
@aaugustin aaugustin removed their assignment Sep 3, 2017
@aaugustin aaugustin mentioned this issue May 5, 2018
Closed
@aaugustin
Copy link
Member Author

There's at least one public use of these APIs: https://github.com/channelcat/sanic/blob/e1c90202682d76361c77adb7bb2176730038466a/sanic/websocket.py#L58-L103

@aaugustin aaugustin mentioned this issue May 6, 2018
Closed
aaugustin added a commit that referenced this issue Jun 4, 2018
@aaugustin
Use Headers throughout the library.
fcaf291 
Document changes.

Fix #210, #256.
@aaugustin aaugustin mentioned this issue Jun 4, 2018
Merged
aaugustin added a commit that referenced this issue Jun 4, 2018
@aaugustin
Use Headers throughout the library.
ae59a27 
Document changes.

Fix #210, #256.
@aaugustin aaugustin removed this from the someday milestone Jun 4, 2018
aaugustin added a commit that referenced this issue Jun 17, 2018
@aaugustin
Use Headers throughout the library.
2037226 
Document changes.

Fix #210, #256.
@aaugustin
Copy link
Member Author

Fixed in #423.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@aaugustin