Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider a better structure for HTTP headers #210

Closed
aaugustin opened this issue Jul 17, 2017 · 2 comments
Closed

Consider a better structure for HTTP headers #210

aaugustin opened this issue Jul 17, 2017 · 2 comments
Labels
enhancement

Comments

@aaugustin
Copy link
Member

Follow up on a suggestion by @cjerdonek here: #200 (comment)

Currently websockets relies http.client.HTTPMessage because:

  • due to an implementation leak, the public API used to document the email.message.EmailMessage type; http.client.HTTPMessage is also available in the stdlib, more appropriate, and API-compatible (it's a thin subclass)
  • I didn't want to reinvent yet another variant of a multi-value dict — but I'm willing to reconsider this now that I dropped the stdlib for parsing HTTP headers
@aaugustin aaugustin mentioned this issue Jul 17, 2017
Merged
aaugustin added a commit that referenced this issue Jul 17, 2017
@aaugustin
Encapsulate creation of HTTP headers.
b57a410 
Since this part is hacky and likely to change in the future (#210),
wrap it into a single function and add tests for the public API we
really care about.
aaugustin added a commit that referenced this issue Jul 17, 2017
@aaugustin
Encapsulate creation of HTTP headers.
a1a6aef 
Since this part is hacky and likely to change in the future (#210),
wrap it into a single function and add tests for the public API we
really care about.
aaugustin added a commit that referenced this issue Jul 17, 2017
@aaugustin
Encapsulate creation of HTTP headers.
00efcc6 
Since this part is hacky and likely to change in the future (#210),
wrap it into a single function and add tests for the public API we
really care about.
@aaugustin
Copy link
Member Author

Not sure we're going to do this. I may end up as wontfix.

@aaugustin aaugustin reopened this Aug 20, 2017
@aaugustin aaugustin added this to the someday milestone Sep 3, 2017
@aaugustin aaugustin changed the title Consider a more lightweight structure for HTTP headers Consider a better structure for HTTP headers Sep 30, 2017
@aaugustin aaugustin mentioned this issue May 6, 2018
Closed
aaugustin added a commit that referenced this issue Jun 4, 2018
@aaugustin
Use Headers throughout the library.
fcaf291 
Document changes.

Fix #210, #256.
@aaugustin aaugustin mentioned this issue Jun 4, 2018
Merged
@aaugustin aaugustin removed this from the someday milestone Jun 4, 2018
@aaugustin
Copy link
Member Author

I did reinvent a multi-value dict in #423 🤷‍♂️

aaugustin added a commit that referenced this issue Jun 4, 2018
@aaugustin
Use Headers throughout the library.
ae59a27 
Document changes.

Fix #210, #256.
aaugustin added a commit that referenced this issue Jun 17, 2018
@aaugustin
Use Headers throughout the library.
2037226 
Document changes.

Fix #210, #256.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@aaugustin