-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Numerous fixes for goeap_proxy #11
Open
EvanCarroll
wants to merge
7
commits into
pyther:master
Choose a base branch
from
EvanCarroll:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@ddrown interested in any feedback yo umay have. |
ddrown
reviewed
Mar 8, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this works for me, I'm able to build a package with these changes
This also fixes #6 |
ddrown
approved these changes
Mar 26, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
error message: The unauthenticated git protocol on port 9418 is no longer supported. Please see https://github.blog/2021-09-01-improving-git-protocol-security-github/ for more information.
* OpenWrt 21.02.0 deprecates "ifname", upgraded this to "device". * Made the errors more verbose, and upgraded them to fatal * Switch to use newer procd_set_param command syntax
* Setting your user in the Dockerfile is generally a bad idea now. Remove this and drop this functionality. If you don't want your user to run as root, and want it to run as a user, then enable user-namespaces in the kernel with podman, or rootless docker. * Fix error with python2, I think this was what pyther#8 was referring to. Python2 isn't needed any more. Alpine no longer ships it in the repo.
* Removed older more esoteric information in README (simplified it). * Update links with examples in entry.sh that aren't dead for x86_64 release * Updated installation instructions with what to do after the image is built to get it on an OpenWRT device * Added a docs/ with configuration for `openeap_proxy`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This takes in a change from @ddrown
This also
ifname