Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.6] Replace importlib_metadata with importlib.metadata on Python 3.8+ (#5539) #5945

Merged
merged 1 commit into from
Oct 11, 2019

Conversation

mimi1vx
Copy link
Contributor

@mimi1vx mimi1vx commented Oct 11, 2019

No description provided.

@nicoddemus
Copy link
Member

Thanks again @mimi1vx,

Can you please rebase now that #5944 has been merged? Thanks!

@codecov
Copy link

codecov bot commented Oct 11, 2019

Codecov Report

Merging #5945 into 4.6-maintenance will increase coverage by 0.27%.
The diff coverage is 71.42%.

Impacted file tree graph

@@                 Coverage Diff                 @@
##           4.6-maintenance    #5945      +/-   ##
===================================================
+ Coverage            95.92%   96.19%   +0.27%     
===================================================
  Files                  115      115              
  Lines                26560    26563       +3     
  Branches              2616     2617       +1     
===================================================
+ Hits                 25477    25552      +75     
+ Misses                 756      704      -52     
+ Partials               327      307      -20
Impacted Files Coverage Δ
testing/test_assertion.py 97.67% <ø> (ø) ⬆️
src/_pytest/config/__init__.py 94.43% <100%> (ø) ⬆️
testing/acceptance_test.py 98.02% <100%> (+0.98%) ⬆️
testing/test_entry_points.py 100% <100%> (ø) ⬆️
testing/test_config.py 99.83% <100%> (+0.32%) ⬆️
src/_pytest/compat.py 95.14% <33.33%> (+2.04%) ⬆️
src/_pytest/fixtures.py 97.55% <0%> (+0.27%) ⬆️
testing/test_capture.py 99.25% <0%> (+0.29%) ⬆️
testing/test_terminal.py 99.84% <0%> (+0.31%) ⬆️
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1cc974c...b9a8465. Read the comment docs.

@nicoddemus nicoddemus merged commit 2c7614a into pytest-dev:4.6-maintenance Oct 11, 2019
@nicoddemus
Copy link
Member

Thanks again @mimi1vx!

Any other fixes you feel should be ported? Otherwise I plan to cut a new 4.6 release later today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants